Skip to content

feat(Modal/Popover/Slideover): add close-prevented event #3127

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
rdjanuar wants to merge 508 commits into from
Closed

feat(Modal/Popover/Slideover): add close-prevented event #3127

rdjanuar wants to merge 508 commits into from

Conversation

@rdjanuar
Copy link
Contributor

@rdjanuar rdjanuar commented Jan 17, 2025 •
edited
Loading

🔗 Linked issue

Resolves #3126

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

📝 Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

@rdjanuar rdjanuar changed the title Issue 3126 feat(Modal): new event. close-prevented Jan 17, 2025
@rdjanuar rdjanuar changed the title feat(Modal): new event. close-prevented feat(Modal): new event close-prevented Jan 17, 2025
@pkg-pr-new
Copy link

pkg-pr-new bot commented Jan 17, 2025 •
edited
Loading 

npm i https://pkg.pr.new/@nuxt/ui@3127

commit: 248e9f1

@rdjanuar rdjanuar added the v3 #1289 label Jan 18, 2025
benjamincanac
benjamincanac reviewed Jan 24, 2025
View reviewed changes
Copy link
Member

@benjamincanac benjamincanac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this should be done on the Slideover and Popover components that have the same behavior with a dismissible prop.

@benjamincanac benjamincanac force-pushed the v3 branch 2 times, most recently from aa74a4f to 87234cb Compare February 4, 2025 15:31
@benjamincanac
Copy link
Member

benjamincanac commented Apr 22, 2025

@rdjanuar Would you mind fixing the conflicts? 😬

@benjamincanac benjamincanac changed the title feat(Modal): new event close-prevented feat(Modal/Popover/Slideover): add close-prevented event Apr 22, 2025
benjamincanac and others added 17 commits April 23, 2025 10:51
@benjamincanac @rdjanuar
chore(release): v3.0.0-beta.3
73544dc
@benjamincanac @rdjanuar
docs(deps): update @nuxt/ui-pro
4847477
@ivanmaxlogiudice @rdjanuar
feat(Input/Textarea): allow null value in model (#3415)
f38eb69
@benjamincanac @rdjanuar
chore(templates): add tsdoc on ui app config key
2c96e8b
@benjamincanac @rdjanuar
docs(installation): improve continuous releases section
466c3ff
@renovate @rdjanuar
chore(deps): update all non-major dependencies (v3) (#3489)
afbe59f 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@benjamincanac @rdjanuar
chore(LinkBase): update types for nuxt@3.16
32c2804
@renovate @benjamincanac @rdjanuar
chore(deps): update dependency tailwind-variants to v1 (v3) (#3499)
f934c27 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@benjamincanac @rdjanuar
fix(Button): missing import
1818ded 
Related to #3417
@renovate @rdjanuar
chore(deps): update all non-major dependencies (v3) (#3497)
51514f6 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@renovate @benjamincanac
@pi0 @rdjanuar
chore(deps): update nuxt framework to ^3.16.0 (v3) (#3484)
2d7a15e 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
Co-authored-by: Pooya Parsa <pooya@pi0.io>
@benjamincanac @rdjanuar
docs(app): add missing cache-key on mdc
1da25ed
@benjamincanac @rdjanuar
chore(deps): update @nuxt/ui-pro
4ca826a
@ivanmaxlogiudice @rdjanuar
fix(Form): input blur validation on submit (#3504)
7c3c4e8
@renovate @rdjanuar
chore(deps): update vueuse monorepo to v13 (v3) (major) (#3512)
e4e963a 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@benjamincanac @rdjanuar
chore(renovate): ignore vaul-vue
229bf56
@benjamincanac @rdjanuar
chore(deps): remove happy-dom resolution
51f9099
benjamincanac and others added 28 commits April 23, 2025 10:52
@benjamincanac @rdjanuar
feat(Select): handle onSelect field in items
83dd613
@benjamincanac @rdjanuar
fix(CommandPalette): prevent hover background on disabled items
146dfa3
@renovate @rdjanuar
chore(deps): update all non-major dependencies (v3) (#3806)
c23bb34 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@benjamincanac @rdjanuar
fix(CommandPalette): consistent alignement with other components
07d2b50
@danielroe @rdjanuar
chore(deps): bump vue-sfc-transformer (#3822)
8d59179
@benjamincanac @rdjanuar
chore(package): export utils
fecec63
@benjamincanac @rdjanuar
docs(showcase): add learnvue.co
54e1abd
@benjamincanac @rdjanuar
docs(form): improve types
de9e262
@sandros94 @rdjanuar
fix(Tree): simplify reusable template types (#3836)
b894fa7
@genu @rdjanuar
feat(OverlayProvider)!: return an overlay instance from .open() (#3829
5e6af76 
)
@benjamincanac @rdjanuar
docs(form): improve joi example
58d00a4
@benjamincanac @rdjanuar
chore(Textarea): put back styles
c903aa7
@HugoRCD @rdjanuar
docs(components): add new og images (#3824)
e920029
@sandros94 @benjamincanac @rdjanuar
chore: run test suite on windows (#3479)
9d57ea9 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@sandros94 @rdjanuar
chore: simplify theme imports in dev (#3851)
2316051
@benjamincanac @rdjanuar
docs: prepare for chat components (#3844)
8aa5c2d
@renovate @rdjanuar
chore(deps): update all non-major dependencies (v3) (#3830)
0b58103 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@SukkaW @rdjanuar
docs(prettier): load from jsdelivr.net instead of unpkg.com (#3575)
a2ce946
@Akryum @benjamincanac @rdjanuar
feat(Tabs): add list-leading and list-trailing slots (#3837)
e69c306 
Co-authored-by: Benjamin Canac <canacb1@gmail.com>
@benjamincanac @rdjanuar
docs(form): display theme
ed59eb3 
Resolves #3752
@HugoRCD @rdjanuar
docs(components): update og images (#3859)
cbb847d
@avenikolay @rdjanuar
feat(locale): add Tajik language (#3850)
03c6aa8
@jwoertink @rdjanuar
docs(components): add missing children field in items (#3846)
bf7b586
@benjamincanac @rdjanuar
fix(components): refactor types after @nuxt/module-builder upgrade (#…
2392702 
…3855)
@maximepvrt @rdjanuar
feat(Form): export loading state (#3861)
0e2cc7d
@benjamincanac @rdjanuar
chore(deps): update @nuxt/ui-pro
8f81906
@benjamincanac @rdjanuar
fix(types): handle ClassValue in ui prop
956a802 
Resolves #3860
@rdjanuar
feat(Modal): new event close-prevented
9e2c2bd
@rdjanuar rdjanuar closed this Apr 23, 2025
@rdjanuar
Copy link
Contributor Author

rdjanuar commented Apr 23, 2025

i made a new pull request u can check here #3958. @benjamincanac

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@benjamincanac benjamincanac Awaiting requested review from benjamincanac benjamincanac is a code owner

Assignees

No one assigned

Labels

v3 #1289

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

close prevented event on Modal