fix(Select/SelectMenu): add responsive text size - #6903
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Plus Run ID: ⛔ Files ignored due to path filters (4)
📒 Files selected for processing (3)
💤 Files with no reviewable changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughSelect and SelectMenu now expose a Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This localized change aligns Select and SelectMenu text sizing across breakpoints and keeps the trigger and search field consistent; no actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Linked Issues checkExplanation The changes address issue Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.) ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
commit: |
🔗 Linked issue
Resolves #6892 (related: #4117, where selects were already called out but #6074 only covered inputs)
❓ Type of change
📚 Description
SelectandSelectMenuwere left out of the responsive text size treatment added in #6074, so they rendertext-smat every width whileInput,Textarea,InputNumberandPinInputstep fromtext-baseon mobile down tomd:text-sm. This made a select visibly smaller than the input next to it on mobile, andSelectMenuwas inconsistent with itself since its search field is a realUInputthat can't drop to 14px on mobile without triggering iOS zoom.The theme already inherits the
fixedvariant and its compound variants frominput, they were just neutered by re-pinnedbaseclasses. This removes those overrides so the responsive sizes flow through, adds thefixedprop to both components like the other form controls, and forwards it to theSelectMenusearch input so trigger and search field always agree.Padding and line-heights are untouched, so control heights stay the same next to buttons.
📝 Checklist