Skip to content

fix(ChatMessages): add missing color to user and assistant props - #6920

Merged
benjamincanac merged 1 commit into
nuxt:v4from
gunhaxxor:patch-3
Sep 4, 2026
Merged

fix(ChatMessages): add missing color to user and assistant props#6920
benjamincanac merged 1 commit into
nuxt:v4from
gunhaxxor:patch-3

Conversation

@gunhaxxor

@gunhaxxor gunhaxxor commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

❓ Type of change

  • 📖 Documentation (updates to the documentation or readme)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • 👌 Enhancement (improving an existing functionality)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

📚 Description

type definition of chatmessages hasn't followed the updated color prop added to chatmessage.

@github-actions github-actions Bot added the v4 #4488 label Sep 4, 2026
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: e7ef6faf-1566-4528-9370-3d422148ec20

📥 Commits

Reviewing files that changed from the base of the PR and between 1272205 and 3850bce.

📒 Files selected for processing (1)
  • src/runtime/components/ChatMessages.vue

Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The ChatMessagesProps<T> interface now includes color in the picked properties for both user and assistant props. This is a type-only change.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Merge Risk: ⚪ Minimal · up to 3850b

ChatMessages now accepts color overrides for user and assistant messages at the type level, with no runtime behavior change or current merge-readiness risk.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Title check ✅ Passed The title clearly identifies the missing color prop in the ChatMessages user and assistant props. It accurately summarizes the primary change.
Description check ✅ Passed The description explains that the ChatMessages type definition is missing the color prop added to ChatMessage. It is directly related to the changeset.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 4, 2026

Copy link
Copy Markdown
npm i https://pkg.pr.new/@nuxt/ui@6920

commit: 3850bce

@codspeed-hq

codspeed-hq Bot commented Sep 4, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 31 untouched benchmarks


Comparing gunhaxxor:patch-3 (3850bce) with v4 (1272205)

Open in CodSpeed

@benjamincanac benjamincanac changed the title fix[types]: added missing chatmessage prop to chatmessages type definition fix(ChatMessages): add missing color to user and assistant props Sep 4, 2026

@benjamincanac benjamincanac left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@benjamincanac
benjamincanac merged commit bbf1e14 into nuxt:v4 Sep 4, 2026
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v4 #4488

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants