Skip to content

Add np.digitize#1117

Merged
bryevdv merged 5 commits intonv-legate:branch-24.01from
bryevdv:bv/digitize
Feb 13, 2024
Merged

Add np.digitize#1117
bryevdv merged 5 commits intonv-legate:branch-24.01from
bryevdv:bv/digitize

Conversation

@bryevdv
Copy link
Copy Markdown
Contributor

@bryevdv bryevdv commented Jan 26, 2024

This PR adds support for np.digitize

Numpy has a custom C function to test monotonicity, but that won't work here. Used a simple adjacency compare, but any suggestions for improvement welcome.

@bryevdv bryevdv added the category:new-feature PR introduces a new feature and will be classified as such in release notes label Jan 26, 2024
@bryevdv bryevdv requested a review from manopapad January 26, 2024 20:10
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Jan 26, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@manopapad
Copy link
Copy Markdown
Contributor

manopapad commented Jan 26, 2024

/ok to test

manopapad
manopapad requested changes Feb 6, 2024
View reviewed changes
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
@bryevdv
Copy link
Copy Markdown
Contributor Author

bryevdv commented Feb 12, 2024

/ok to test

@bryevdv bryevdv requested a review from manopapad February 13, 2024 18:02
@bryevdv bryevdv merged commit af3f0ff into nv-legate:branch-24.01 Feb 13, 2024
@bryevdv bryevdv deleted the bv/digitize branch February 13, 2024 18:32
@bryevdv
Copy link
Copy Markdown
Contributor Author

bryevdv commented Feb 13, 2024

@manopapad should this be ported to internal?

@manopapad
Copy link
Copy Markdown
Contributor

manopapad commented Feb 13, 2024

Yeah, it looks like @magnatelee is already doing a merge from public.

@manopapad manopapad mentioned this pull request Feb 14, 2024
Closed
22 tasks
manopapad pushed a commit that referenced this pull request Feb 18, 2025
@bryevdv
Recent ports from public repo (#146)
30fd2c0 
* add np.digitize (ref: #1117)

* add np.diff (ref: #636)

* add np.load (ref: #1126)

* add cov (ref: #1129)

* add average (ref: #1124)

* add logical reductions (ref: #1123)

* fix docstring syntax

* review comments

* fix import

* fix error from update

* fix copy pasta
srivarra pushed a commit to srivarra/cupynumeric that referenced this pull request Oct 11, 2025
@aschaffer
scan-by-key impl. (nv-legate#1117)
b7cc22b
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manopapad manopapad manopapad approved these changes

Assignees

No one assigned

Labels

category:new-feature PR introduces a new feature and will be classified as such in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@bryevdv @manopapad