Skip to content

Adding average functionality#1124

Merged
manopapad merged 13 commits intonv-legate:branch-24.03from
JosephGuman:average
Mar 9, 2024
Merged

Adding average functionality#1124
manopapad merged 13 commits intonv-legate:branch-24.03from
JosephGuman:average

Conversation

@JosephGuman
Copy link
Copy Markdown

@JosephGuman JosephGuman commented Feb 15, 2024

No description provided.

Initial implemtation of average based off of and designed to mimic be…
54766de 
…havior of numpy's average function in cunumeric Signed-off-by: Joseph Guman <joeytg@stanford.edu>
@copy-pr-bot
Copy link
Copy Markdown
Contributor

copy-pr-bot Bot commented Feb 15, 2024

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@rohany rohany requested review from bryevdv and manopapad February 15, 2024 18:52
@bryevdv bryevdv added the category:improvement PR introduces an improvement and will be classified as such in release notes label Feb 15, 2024
@bryevdv
Copy link
Copy Markdown
Contributor

bryevdv commented Feb 15, 2024

/ok to test

bryevdv
bryevdv suggested changes Feb 15, 2024
View reviewed changes
Comment thread cunumeric/module.py Outdated
Comment thread tests/integration/test_average.py
Expanding test functionality of average and removing redundancy with …
b5908b2 
…boilerplate Signed-off-by: Joseph Guman <joeytg@stanford.edu>
@marcinz marcinz changed the base branch from branch-24.01 to branch-24.03 February 22, 2024 01:02
manopapad
manopapad requested changes Feb 27, 2024
View reviewed changes
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py
Comment thread cunumeric/module.py
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
Comment thread cunumeric/module.py Outdated
@manopapad
Copy link
Copy Markdown
Contributor

manopapad commented Feb 27, 2024

/ok to test

@manopapad manopapad mentioned this pull request Feb 28, 2024
Closed
22 tasks
@manopapad
Copy link
Copy Markdown
Contributor

manopapad commented Mar 5, 2024

Leaving a note here, to update #1129 if this is merged first.

JosephGuman and others added 8 commits March 7, 2024 13:47
@JosephGuman @manopapad
Update cunumeric/module.py
67945a4 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@JosephGuman @manopapad
Update cunumeric/module.py
68aa512 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@JosephGuman @manopapad
Update cunumeric/module.py
7cfbc7b 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@JosephGuman @manopapad
Update cunumeric/module.py
42fbd33 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@JosephGuman @manopapad
Update cunumeric/module.py
57ef607 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@JosephGuman @manopapad
Update cunumeric/module.py
d138ed3 
Co-authored-by: Manolis Papadakis <manopapad@gmail.com>
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
4a99324 
for more information, see https://pre-commit.ci
@manopapad
Add function to doc listing
01f0d59
@manopapad
Copy link
Copy Markdown
Contributor

manopapad commented Mar 8, 2024

/ok to test

@manopapad manopapad added category:new-feature PR introduces a new feature and will be classified as such in release notes and removed category:improvement PR introduces an improvement and will be classified as such in release notes labels Mar 8, 2024
@manopapad
Copy link
Copy Markdown
Contributor

manopapad commented Mar 9, 2024

/ok to test

@manopapad manopapad merged commit 788fed0 into nv-legate:branch-24.03 Mar 9, 2024
manopapad pushed a commit that referenced this pull request Feb 18, 2025
@bryevdv
Recent ports from public repo (#146)
30fd2c0 
* add np.digitize (ref: #1117)

* add np.diff (ref: #636)

* add np.load (ref: #1126)

* add cov (ref: #1129)

* add average (ref: #1124)

* add logical reductions (ref: #1123)

* fix docstring syntax

* review comments

* fix import

* fix error from update

* fix copy pasta
srivarra pushed a commit to srivarra/cupynumeric that referenced this pull request Oct 11, 2025
@manopapad
Don't specify CUDA architecture in install.py (nv-legate#1124)
5bce9f2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@manopapad manopapad manopapad approved these changes

+1 more reviewer

@bryevdv bryevdv bryevdv requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category:new-feature PR introduces a new feature and will be classified as such in release notes

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@JosephGuman @bryevdv @manopapad