Skip to content

Conversation

@manopapad
Copy link
Contributor

Single Fills only for now; not sure if IndexFills are necessary.

@manopapad manopapad added the category:new-feature PR introduces a new feature and will be classified as such in release notes label Sep 20, 2022
assert isinstance(self._lhs.storage, RegionField)
assert isinstance(self._value.storage, Future)
fill = Fill(
self._lhs.storage.region,
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This assumes that the Storage attached to a Store is always an exact match for the extent which that Store represents (i.e. any attached transforms that restrict the extent of the region have already been applied through partition operations on the attached Storage). I suspect this is true, but it's not trivially obvious from the code.

@magnatelee
Copy link
Contributor

Single Fills only for now; not sure if IndexFills are necessary.

Mike reminded that a single fill on a root region would coalesce the equivalence set, which later should be refined. So we should support index fills as well and I don't think it would be terribly difficult to add.

@magnatelee
Copy link
Contributor

@manopapad can you add provenance tracking for fills? 44cc941

@manopapad
Copy link
Contributor Author

@manopapad can you add provenance tracking for fills? 44cc941

12c9b2c

@manopapad manopapad merged commit 72a3693 into nv-legate:branch-22.10 Sep 24, 2022
@manopapad manopapad deleted the fill-op branch January 27, 2023 18:55
manopapad added a commit that referenced this pull request Mar 5, 2025
Replace `mamba` with `conda`, since `libmamba` is now the default anyway.

Add note to actually activate the conda environment.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

category:new-feature PR introduces a new feature and will be classified as such in release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants