-
Notifications
You must be signed in to change notification settings - Fork 63
Add Fill operation #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Fill operation #369
Conversation
| assert isinstance(self._lhs.storage, RegionField) | ||
| assert isinstance(self._value.storage, Future) | ||
| fill = Fill( | ||
| self._lhs.storage.region, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that the Storage attached to a Store is always an exact match for the extent which that Store represents (i.e. any attached transforms that restrict the extent of the region have already been applied through partition operations on the attached Storage). I suspect this is true, but it's not trivially obvious from the code.
Mike reminded that a single fill on a root region would coalesce the equivalence set, which later should be refined. So we should support index fills as well and I don't think it would be terribly difficult to add. |
|
@manopapad can you add provenance tracking for fills? 44cc941 |
|
Replace `mamba` with `conda`, since `libmamba` is now the default anyway. Add note to actually activate the conda environment.
Single Fills only for now; not sure if IndexFills are necessary.