-
Notifications
You must be signed in to change notification settings - Fork 63
Add Fill operation #369
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Add Fill operation #369
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
d3b4164
Fixes to InstanceManager
manopapad 118a15c
Add Fill operation
manopapad 0c76c7d
Typo in comment
manopapad 2c0cfb7
Use set for filtered_regions, instead of vector
manopapad bf7eb02
Merge branch 'instmgr-fixes' into fill-op
manopapad 3e8beb7
Fix some types
manopapad e2d4cd2
Add IndexFill
manopapad 0f3aa9d
Pass unique IDs to Copies and Fills
manopapad 1a211ce
Pass Domain to Fill operation creation
manopapad 705c208
Record Fill lhs partition, so that the solver can find it
manopapad d7dfc06
Set key partition on fill lhs
manopapad 996ead2
Merge branch 'branch-22.10' into fill-op
manopapad e0e8e27
Merge branch 'branch-22.10' into fill-op
manopapad 12c9b2c
Add provenance for Fills
manopapad File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This assumes that the
Storageattached to aStoreis always an exact match for the extent which thatStorerepresents (i.e. any attached transforms that restrict the extent of the region have already been applied through partition operations on the attachedStorage). I suspect this is true, but it's not trivially obvious from the code.