Add copy version number button to the about dialog #18667
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds a "Copy version number" button to the NVDA about dialog, making it easier for users to copy version information for support purposes. The button copies the version string in the format source-master-ed86524 (2025.3.0.0).
Key changes:
- Added a copy button to the about dialog using the existing MessageDialog framework
- Implemented a callback function to copy version information to clipboard
- Updated typing annotations to use newer Python syntax
LeonarddeR
reviewed
Aug 11, 2025
Co-authored-by: Leonard de Ruijter <3049216+LeonarddeR@users.noreply.github.com>
seanbudd
commented
Aug 11, 2025
seanbudd
added
the
conceptApproved
SaschaCowley
approved these changes
Aug 15, 2025
OzancanKaratas
pushed a commit
to OzancanKaratas/nvda
that referenced
this pull request
Aug 17, 2025
Raised in nvaccess#15320 (comment) Summary of the issue: There's no easy way for an NVDA user to copy the version information from the about dialog Description of user facing changes: A button has been added to the about dialog to copy the version information. example `source-master-ed86524 (2025.3.0.0)` Description of developer facing changes: none Description of development approach: Added a button the message dialog Testing strategy: Tested by opening the about dialog and ensuring the version number is copied Known issues with pull request: none
OzancanKaratas
pushed a commit
to OzancanKaratas/nvda
that referenced
this pull request
Aug 18, 2025
Raised in nvaccess#15320 (comment) Summary of the issue: There's no easy way for an NVDA user to copy the version information from the about dialog Description of user facing changes: A button has been added to the about dialog to copy the version information. example `source-master-ed86524 (2025.3.0.0)` Description of developer facing changes: none Description of development approach: Added a button the message dialog Testing strategy: Tested by opening the about dialog and ensuring the version number is copied Known issues with pull request: none
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Link to issue number:
Raised in #15320 (comment)
Summary of the issue:
There's no easy way for an NVDA user to copy the version information from the about dialog
Description of user facing changes:
A button has been added to the about dialog to copy the version information.
example
source-master-ed86524 (2025.3.0.0)Description of developer facing changes:
none
Description of development approach:
Added a button the message dialog
Testing strategy:
Tested by opening the about dialog and ensuring the version number is copied
Known issues with pull request:
none
Code Review Checklist:
@coderabbitai summary