remove glob import from versionInfo

[seanbudd]

Link to issue number:

Follow up to #18680

Summary of the issue:

We use a glob import in versionInfo which is not recommended

Description of user facing changes:

Description of developer facing changes:

versionInfo no longer imports all variables from buildVersion

Description of development approach:

Update imports

Testing strategy:

Smoke tests

Known issues with pull request:

None

Code Review Checklist:

• Documentation:
  • Change log entry
  • User Documentation
  • Developer / Technical Documentation
  • Context sensitive help for GUI changes
• Testing:
  • Unit tests
  • System (end to end) tests
  • Manual testing
• UX of all users considered:
  • Speech
  • Braille
  • Low Vision
  • Different web browsers
  • Localization in other languages / culture than English
• API is compatible with existing add-ons.
• Security precautions taken.

@coderabbitai summary

[Copilot]

Pull Request Overview

This PR removes the glob import (star import) from versionInfo.py to follow Python best practices and improve code clarity by explicitly importing only required variables.

• Replaces from buildVersion import * with explicit imports in versionInfo.py
• Updates all modules importing version-related variables to use buildVersion instead of versionInfo where appropriate
• Updates documentation and configuration files to reference the correct module for version information

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file

File	Description
source/versionInfo.py	Replaces glob import with explicit imports and updates string formatting
source/updateCheck.py	Changes imports from versionInfo to buildVersion for version checking
source/setup.py	Moves build-related imports to buildVersion module
source/installer.py	Updates version references to use buildVersion instead of versionInfo
source/gui/startupDialogs.py	Changes window title to use buildVersion.name
source/gui/init.py	Updates frame and system tray icon names to use buildVersion
source/core.py	Changes message window name to use buildVersion
source/appModules/nvda.py	Updates NVDA menu name to use buildVersion
sconstruct	Updates build configuration to use buildVersion variables
projectDocs/dev/developerGuide/developerGuide.md	Updates documentation example to use buildVersion
projectDocs/dev/developerGuide/conf.py	Updates Sphinx configuration to use buildVersion
appx/sconscript	Updates AppX package configuration to use buildVersion

---

_{Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.}

[LeonarddeR]

There are many add-ons that use versionInfo.version_year and similar constants to check compatibility. I see why the glob was removed, but this is a kind of API breakage that we can and should avoid IMO.

[SaschaCowley]

@LeonarddeR one of my least favourite features of Python is that there is no (good) way of disallowing transitive imports. I do think transitive imports are a useful feature, but I find it deeply irritating that because I import something into my module, it necessarily becomes available for import from my module. It makes problems like this almost unavoidable. I would really like if we could have - and enforce - a single, canonical import path for all public API symbols.

All that being said, while painful I think this code clean up is ultimately positive.