Enable gitsigns.nvim recommended keymaps by default - #2158
Merged
Conversation
Contributor
Author
|
@oriori1703 Thank you! :) |
dam9000
added a commit
to dam9000/kickstart-modular.nvim
that referenced
this pull request
Sep 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Please consider merging this.
I see no drawback in having the gitsigns.nvim recommended keymaps be enabled by default
The initial reason these were outside of init.lua was so that the line count of init.lua was kept relatively low and the reason it was disabled by default was the wish that an init.lua without any extra files (plugins) would work just as well - in case someone just copied the init.lua file and not the rest of the accompanying plugins.
Now with the keymaps integrated into init.lua, there is no need to have them commented out, there is nothing left to protect against, it just adds friction to what is a sensible default.
related: #2092