Restore primitive as its own engine module - #340
Merged
Conversation
BoundingBox, Confidence, Language, TimeSpan, and friends are first-class value types callers reach for directly — building Inclusion annotations, constructing a Scope, comparing entity confidences. They deserve their own module rather than being buried under entity. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
martsokha
added
refactor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BoundingBox,Confidence,Language,TimeSpan, and friends are first-class value types callers reach for directly — buildingInclusionannotations, constructing aScope, comparing entity confidences. They deserve their own module rather than being buried underentity.Engine root goes from 5 modules to 6: adds
primitiveback alongsideentity,modality,plan,policy,provider.Test plan
🤖 Generated with Claude Code