Skip to content

make use of nw.Window.open to open default window#43

Open
ghostoy wants to merge 3 commits intonwjs:nw17from
ghostoy:issue-5247
Open

make use of nw.Window.open to open default window#43
ghostoy wants to merge 3 commits intonwjs:nw17from
ghostoy:issue-5247

Conversation

@ghostoy
Copy link
Copy Markdown
Member

@ghostoy ghostoy commented Sep 1, 2016

The original logic in default.js is duplicated to the implementation
in nw.Window.open, which could easily bring inconsistancy or bugs.
e.g. in nwjs/nw.js#5247, x and y parameters are missed in the script.
Just make use of nw.Window.open to open the default window can fix
these issues.

chrome-cron and others added 3 commits August 31, 2016 01:35
Publish DEPS for Chromium 53.0.2785.90
21e404b
@rogerwang
nwjs master
985af54
make use of nw.Window.open to open default window
e0c3b79 
The original logic in `default.js` is duplicated to the implementation
in `nw.Window.open`, which could easily bring inconsistancy or bugs.
e.g. in nwjs/nw.js#5247, `x` and `y` parameters are missed in the script.
Just make use of `nw.Window.open` to open the default window can fix
these issues.
@rogerwang rogerwang force-pushed the nw17 branch 2 times, most recently from 3682723 to 0b13b2d Compare September 6, 2016 01:50
rogerwang pushed a commit that referenced this pull request Sep 7, 2016
@fgorski
[Offline pages] Fixing a crash when notification for removed download…
a206610 
…ed page is clicked

BUG=641858
R=dimich@chromium.org,dewittj@chromium.org

Review-Url: https://codereview.chromium.org/2285163003
Cr-Commit-Position: refs/heads/master@{#415122}
(cherry picked from commit 76e9521)

Review URL: https://codereview.chromium.org/2291243002 .

Cr-Commit-Position: refs/branch-heads/2840@{#43}
Cr-Branched-From: 1ae106d-refs/heads/master@{#414607}
@rogerwang rogerwang force-pushed the nw17 branch 6 times, most recently from 8e30c84 to c599298 Compare September 14, 2016 23:20
@rogerwang rogerwang force-pushed the nw17 branch 6 times, most recently from 151b8e5 to d35fc0b Compare September 22, 2016 05:55
@ghostoy
Copy link
Copy Markdown
Member Author

ghostoy commented Oct 26, 2016

@rogerwang This PR will also fix regression in nwjs/nw.js#5387. And it will prevent such regressions caused by inconsistent options between nw.Window.open and window fields in package.json. Please consider to merge it.

@ghostoy ghostoy mentioned this pull request Nov 8, 2016
Closed
@ghostoy
Copy link
Copy Markdown
Member Author

ghostoy commented Nov 8, 2016

@rogerwang Please review and merge this patch in order to prevent future regressions.

rogerwang pushed a commit that referenced this pull request Dec 5, 2016
@zetafunction
Don't use isURLAllowed() to determine if a frame element gets a Layou…
4e0c05d 
…tObject.

What the style recalc code really wants to do is avoid creating a
LayoutObject if the frame load was blocked. The best way to detect
this is checking if contentFrame() is non-null.

Since this breaks some unit tests that manually bootstrap child
frame creation, this CL also remove the custom bootstrapping code
in favor of using the standard FrameLoaderClient interfaces: this
removes a bunch of code duplication for setting up the FrameView
of a child frame.

BUG=618138
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2

Review-Url: https://codereview.chromium.org/2504573002
Cr-Commit-Position: refs/heads/master@{#433341}
(cherry picked from commit 8a8505d)

Review URL: https://codereview.chromium.org/2520823003 .

Cr-Commit-Position: refs/branch-heads/2924@{#43}
Cr-Branched-From: 3a87aec-refs/heads/master@{#433059}
GnorTech pushed a commit that referenced this pull request Jan 29, 2017
@denniskempin
Handle floating point coordinates from ozone to exosphere
460a6b8 
Most touch coordinate handling within chrome is done with gfx:Points.
Rounding to points works well for most cases, but really degrades
user experience for hand writing with an on-screen stylus.
This change will add variants to a couple of coordinate transformation
methods that will use gfx::PointF instead of gfx::Point.
This allows touch coordinates to be passed from ozone to exosphere in
sub-pixel accuracy, allowing those coordinates to be used in arc++
note taking apps.

BUG=681235
TEST=Test with arc++ drawing apps without smoothing. Lines should
be smooth without distinct steps.
NOPRESUBMIT=true
NOTRY=true

Review-Url: https://codereview.chromium.org/2648583003
Cr-Commit-Position: refs/heads/master@{#445510}
(cherry picked from commit 951e1c2)

Review-Url: https://codereview.chromium.org/2654653002
Cr-Commit-Position: refs/branch-heads/2987@{#43}
Cr-Branched-From: ad51088-refs/heads/master@{#444943}
rogerwang pushed a commit that referenced this pull request Mar 11, 2017
@sebsg
[Merge-58] Fix focus bug in the expiration date CVC unmaskp prompt.
88b230f 
BUG=697408

Review-Url: https://codereview.chromium.org/2722283004
Cr-Commit-Position: refs/heads/master@{#454594}
(cherry picked from commit 298bf2e)

Review-Url: https://codereview.chromium.org/2737773002 .
Cr-Commit-Position: refs/branch-heads/3029@{#43}
Cr-Branched-From: 939b32e-refs/heads/master@{#454471}
GnorTech pushed a commit that referenced this pull request Apr 26, 2017
Incrementing VERSION to 59.0.3071.12
cc301ab 
Cr-Commit-Position: refs/branch-heads/3071@{#43}
Cr-Branched-From: a106f0a-refs/heads/master@{#464641}
GnorTech pushed a commit that referenced this pull request Aug 5, 2017
Fix multiline incremental insertion
ac3eaa4 
The previous fixing attempt for multiline insertion
(http://crrev.com/2680733002) only worked for two-line text, and this CL
allows for incremental insertion of three or more lines of text.

Since selection is shifted after insertion, we need to update the
selection start offset that will be used in adjusting selection for
incremental insertion.

BUG=712380

(cherry picked from commit 20b5f33)

Change-Id: Ibb3212bd78fc7e30232aaa6b780c0c1182b63d1c
Reviewed-on: https://chromium-review.googlesource.com/580496
Commit-Queue: Yoshifumi Inoue <yosin@chromium.org>
Reviewed-by: Yoshifumi Inoue <yosin@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#488616}
Reviewed-on: https://chromium-review.googlesource.com/585770
Reviewed-by: Changwan Ryu <changwan@chromium.org>
Cr-Commit-Position: refs/branch-heads/3163@{#43}
Cr-Branched-From: ff259ba-refs/heads/master@{#488528}
GnorTech pushed a commit that referenced this pull request Sep 14, 2017
Add DidStopFlinging support for TouchSelection Editing in OOPIFs.
c8c8f08 
This CL adds handlers to notify RenderWidgetHostViewChildFrame and its
TouchSelectionControllerClientChildFrame when main-thread flings complete
in an oopif renderer.

This is necessary for correct operation of the touch selection editing
handles during touch scroll.

TBR=wjmaclean@chromium.org

(cherry picked from commit 351726f)

Bug: 756184
Change-Id: Ibb4cff0e09119c5c95cd36d6f3ab6737a59be7b3
Reviewed-on: https://chromium-review.googlesource.com/647827
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#499294}
Reviewed-on: https://chromium-review.googlesource.com/652588
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/branch-heads/3202@{#43}
Cr-Branched-From: fa6a5d8-refs/heads/master@{#499098}
GnorTech pushed a commit that referenced this pull request Oct 27, 2017
Link Cronet static framework with Xcode toolchain libraries
f4d0dae 
BUG=774814

Cq-Include-Trybots: master.tryserver.chromium.android:android_cronet_tester;master.tryserver.chromium.mac:ios-simulator-cronet
Change-Id: I575425a128689729741093e43d6798f2252b5ec6
Reviewed-on: https://chromium-review.googlesource.com/722100
Commit-Queue: Andrei Kapishnikov <kapishnikov@chromium.org>
Reviewed-by: Misha Efimov <mef@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#509260}(cherry picked from commit dd77053)
Reviewed-on: https://chromium-review.googlesource.com/723479
Cr-Commit-Position: refs/branch-heads/3239@{#43}
Cr-Branched-From: adb61db-refs/heads/master@{#508578}
rogerwang pushed a commit that referenced this pull request Jan 29, 2018
Incrementing VERSION to 65.0.3325.13
fdb446c 
TBR=dimu@chromium.org

Change-Id: Ibed2bd3179c892d767a4b06d356e973760d1896c
Reviewed-on: https://chromium-review.googlesource.com/882262
Reviewed-by: chrome-release-bot@chromium.org <chrome-release-bot@chromium.org>
Cr-Commit-Position: refs/branch-heads/3325@{#43}
Cr-Branched-From: bc084a8-refs/heads/master@{#530369}
GnorTech pushed a commit that referenced this pull request Mar 20, 2018
@pavelfeldman
DevTools: "Inspect" context menu in an OOPIF doesn't expand to elemen…
66b1004 
…t on first try

TBR=pfeldman@chromium.org

(cherry picked from commit 6d73147)

Bug: 817653
Change-Id: I29fed9cfc734439aa4a97cf591dafc440232de12
Reviewed-on: https://chromium-review.googlesource.com/943938
Reviewed-by: Dmitry Gozman <dgozman@chromium.org>
Commit-Queue: Pavel Feldman <pfeldman@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#540337}
Reviewed-on: https://chromium-review.googlesource.com/952285
Reviewed-by: Pavel Feldman <pfeldman@chromium.org>
Cr-Commit-Position: refs/branch-heads/3359@{#43}
Cr-Branched-From: 66afc5e-refs/heads/master@{#540276}
rogerwang pushed a commit that referenced this pull request Apr 25, 2018
@zhenyao
Quit the second GPU process when its job to gather the DX12/Vulkan in…
450f31f 
…fo is complete.

The previous checkin for "996594:Adding SupportsDX12 and SupportsVulkan to UMA histogram
for the Windows platform" did not quit the GPU process after the job is complete.

base::RunLoop().QuitCurrentWhenIdleDeprecated() is added to the end of the function of the second
GPU process to fix this issue.

BUG=832596
TEST=manual,Chrome task manager
R=​zmo@chromium.org

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel
Change-Id: Ifadb24d39b24a9a5a6cdc0c33e66bcfc42d5a5a7
Reviewed-on: https://chromium-review.googlesource.com/1012595
Reviewed-by: Zhenyao Mo <zmo@chromium.org>
Commit-Queue: Maggie Chen <magchen@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#550751}(cherry picked from commit 018244f)
Reviewed-on: https://chromium-review.googlesource.com/1014204
Cr-Commit-Position: refs/branch-heads/3396@{#43}
Cr-Branched-From: 9ef2aa8-refs/heads/master@{#550428}
rogerwang pushed a commit that referenced this pull request Jun 19, 2018
@kpaulh
Add UseCounter metrics for WebAuthn to UKM
6fec4cd 
Bug: 803825
Change-Id: I7267668d906fc3335d28f4d71ef35d60dc0d8611
Reviewed-on: https://chromium-review.googlesource.com/1070307
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Reviewed-by: Bryan McQuade <bmcquade@chromium.org>
Commit-Queue: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#562438}(cherry picked from commit b5f7b9b)
Reviewed-on: https://chromium-review.googlesource.com/1079307
Reviewed-by: Kim Paulhamus <kpaulhamus@chromium.org>
Cr-Commit-Position: refs/branch-heads/3440@{#43}
Cr-Branched-From: 010ddcf-refs/heads/master@{#561733}
GnorTech pushed a commit that referenced this pull request Aug 4, 2018
@speednoisemovement
Cocoa: Retain extension overflow menu item when readding
6b8222a 
Bug: 866748
Change-Id: If48fa3bf307e8dc7876360840acced8e83f7572a
Reviewed-on: https://chromium-review.googlesource.com/1148015
Reviewed-by: Robert Sesek <rsesek@chromium.org>
Commit-Queue: Leonard Grey <lgrey@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#577522}(cherry picked from commit aec829b)
Reviewed-on: https://chromium-review.googlesource.com/1148482
Reviewed-by: Leonard Grey <lgrey@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#43}
Cr-Branched-From: 271eaf5-refs/heads/master@{#576753}
rogerwang pushed a commit that referenced this pull request Sep 15, 2018
@cdmarina
Reland "Sandbox audio service on Linux."
193308c 
This is a reland of 2ea45c0

Reason for reland: Fixed i386 build.

TBR=rsesek@chromium.org, nasko@chromium.org, olka@chromium.org


Original change's description:
> Sandbox audio service on Linux.
>
> Run audio service process in sandboxed mode on Linux. Sandbox is enabled behind finch experiment flag:
> --enable-features=AudioServiceStreams,AudioServiceOutOfProcess,AudioServiceSandbox
>
> TBR=mpdenton@chromium.org, palmer@chromium.org, tsepez@chromium.com
>
>
> Bug: 850878
> Change-Id: Iba6b84adc8c4a62ac4c20d5b36aa4f21b36a1574
> Reviewed-on: https://chromium-review.googlesource.com/1160844
> Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
> Reviewed-by: Tom Sepez <tsepez@chromium.org>
> Reviewed-by: Nasko Oskov <nasko@chromium.org>
> Reviewed-by: Robert Sesek <rsesek@chromium.org>
> Reviewed-by: Olga Sharonova <olka@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#588100}


Bug: 850878
Change-Id: Id56fb1b95cfcc8b78c013e7f1a90b63a419205ba
Reviewed-on: https://chromium-review.googlesource.com/1199506
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Reviewed-by: Nasko Oskov <nasko@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Reviewed-by: Will Harris <wfh@chromium.org>
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#588351}(cherry picked from commit f2fc90b)
Reviewed-on: https://chromium-review.googlesource.com/1206330
Cr-Commit-Position: refs/branch-heads/3538@{#43}
Cr-Branched-From: 79f7c91-refs/heads/master@{#587811}
rogerwang pushed a commit that referenced this pull request Oct 31, 2018
Download Home : Fixed close button behavior on tablets
b24b397 
The close button shouldn't be show on the tablets which was broken.

Bug: 894625
Change-Id: I4f9740132a329d2e62d43b8dc0ef858780a21c91
Reviewed-on: https://chromium-review.googlesource.com/c/1278165
Commit-Queue: Shakti Sahu <shaktisahu@chromium.org>
Reviewed-by: David Trainor <dtrainor@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#599422}(cherry picked from commit 8d4e074)
Reviewed-on: https://chromium-review.googlesource.com/c/1283989
Reviewed-by: Shakti Sahu <shaktisahu@chromium.org>
Cr-Commit-Position: refs/branch-heads/3578@{#43}
Cr-Branched-From: 4226ddf-refs/heads/master@{#599034}
rogerwang pushed a commit that referenced this pull request Dec 18, 2018
@pbos
Fix escaping focus traversal from LoginUserMenu
3c37c04 
Makes use of SetFocusTraversableParent to declare where focus should go
after the view has been fully traversed.

Fixes infinite recursion where LoginUserMenu would redirect focus to its
anchor and then forward focus (which takes it inside LoginUserMenu as
the dialog is anchored).

Bug: chromium:901456
Change-Id: I138be71866760de84980f5e4ca0c1b42d6d1793f
Reviewed-on: https://chromium-review.googlesource.com/c/1338222
Commit-Queue: Peter Boström <pbos@chromium.org>
Reviewed-by: Jacob Dufault <jdufault@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#613367}(cherry picked from commit 6b73dc9)
Reviewed-on: https://chromium-review.googlesource.com/c/1362221
Reviewed-by: Peter Boström <pbos@chromium.org>
Cr-Commit-Position: refs/branch-heads/3626@{#43}
Cr-Branched-From: d897fb1-refs/heads/master@{#612437}
rogerwang pushed a commit that referenced this pull request Feb 10, 2019
@chaopeng @kjmcnee
M73: Use GetDeviceScaleFactor to get scale factor for coord space tra…
8e0ce55 
…nsform

TBR=avi@chromium.org

Use GetDeviceScaleFactor to get scale factor for coord space transform

The device scale factor is not properly applied in
CrossProcessFrameConnector::TransformPointToLocalCoordSpaceLegacy
We're using current_surface_scale_factor() which does not seem to
provide the correct value. We want GetDeviceScaleFactor().

Test: SitePerProcessInternalsHitTestBrowserTest.ScrollNestedLocalNonFastScrollableDiv
after crrev.com/c/1427607 landed

Bug: 923069
Change-Id: Iae748780d0657d7674cf4ba76a276ad03cc28a74
Reviewed-on: https://chromium-review.googlesource.com/c/1435834
Reviewed-by: Kevin McNee <mcnee@chromium.org>
Reviewed-by: Avi Drissman <avi@chromium.org>
Commit-Queue: Jianpeng Chao <chaopeng@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#626115}(cherry picked from commit 2154953)
Reviewed-on: https://chromium-review.googlesource.com/c/1443648
Cr-Commit-Position: refs/branch-heads/3683@{#43}
Cr-Branched-From: e510299-refs/heads/master@{#625896}
rogerwang pushed a commit that referenced this pull request Mar 24, 2019
[Tab Capture] Ensure CAPTURE_UPDATE_RECT aligns with I420 subsample b…
a1d098e 
…oundaries

When outputting frames in I420 format, the CAPTURE_UPDATE_RECT set by tab
capture must align with subsample boundaries. Before this CL the
CAPTURE_UPDATE_RECT was computed with single pixel precision. This CL
expands the CAPTURE_UPDATE_RECT such that it aligns with the subsample
size of 2.

Test: viz_unittests
Bug: 930186
Change-Id: I4358fc933ff0cfff41c9265a74e9abb351446ae6
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1507116
Commit-Queue: Christian Fremerey <chfremer@chromium.org>
Reviewed-by: Yuri Wiitala <miu@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#638888}(cherry picked from commit b4d9475b41f992cfb202fe9b35cc7b86a983342b)
Reviewed-on: https://chromium-review.googlesource.com/c/chromium/src/+/1518338
Reviewed-by: Christian Fremerey <chfremer@chromium.org>
Cr-Commit-Position: refs/branch-heads/3729@{#43}
Cr-Branched-From: d4a8972-refs/heads/master@{#638880}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@ghostoy @rogerwang