Skip to content

docs: Add some "shallow" docs for consensus and general cases - #3

Merged
milltay merged 9 commits into
nyksnet:mainfrom
KaffinPX:docs
Aug 2, 2026
Merged

docs: Add some "shallow" docs for consensus and general cases#3
milltay merged 9 commits into
nyksnet:mainfrom
KaffinPX:docs

Conversation

@KaffinPX

@KaffinPX KaffinPX commented Aug 2, 2026

Copy link
Copy Markdown
Collaborator

Also fixes a RPC type issue

@KaffinPX
KaffinPX requested a review from milltay August 2, 2026 00:08
@milltay
milltay merged commit 71a5f9f into nyksnet:main Aug 2, 2026
4 of 5 checks passed
@milltay

milltay commented Aug 2, 2026

Copy link
Copy Markdown
Contributor

Reviewed and merged. Full-workspace cargo check clean on the branch; the RpcNetwork wrapper keeps the wire format identical (Display/FromStr round-trip) and the RpcBlockSelector alias removal is wire-neutral, so external clients are unaffected.

Follow-up d35c97e on main fixes small docs issues found in review: --rpc-listen--listen-rpc (actual clap flag), broken transactions.md relative link, blob/masterblob/main in the ops.rs link, and a stray paren in mining.md.

One note: RPC_API_VERSION moved 2 → 1 — treated it as an intentional reset (no in-repo consumers; v2 never shipped pre-relaunch). Flag if that read is wrong.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants