You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Reviewed against current main (88eea0f). Three things before this can land:
Rebase needed. The branch conflicts with main in consensus/src/mutator_set/mutator_set_accumulator.rs (the /// whitespace line). Careful resolving it: this branch predates feat(node): Fix spammy multi-hop warns #7, so taking the file wholesale reverts feat(node): Fix spammy multi-hop warns #7's - 1 off-by-one fix in active_window_chunk_interval. Keep main's - 1 and your ///.
The Lints job fails on the merged tree.cargo clippy --workspace --tests -- -D warnings hits 7 errors (2x unused_async, collapsible_if, large_enum_variant, match_wildcard_for_single_variants in nyks-consensus; dead-code reset_schema + missing-docs in nyks-database), and cargo fmt --check fails on node/src/application/config/cli_args.rs import order (inherited from feat(node): Fix spammy multi-hop warns #7). Either fix these in this PR or relax -D warnings initially; otherwise main gets a permanently red job the moment this merges.
Is deleting release.yml intentional? The cargo-dist failure was only the 0.30.2 vs 0.30.3 version pin. If dropping release automation is the plan, fine, but make it explicit; otherwise bump the pin instead.
The trigger fix (on: [push, pull_request]) and the .cargo/config.toml env-table fix are both correct and wanted. One more ask: several deleted doc examples (locks crate, the compile_fail test in block/mod.rs guarding #[readonly::make]) were repairable the same way you fixed timestamp.rs, and the compile_fail one was a real regression guard. Worth restoring rather than deleting.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.