Feature/gateway shared key generation#272
Merged
futurechimp merged 41 commits intodevelopfrom Jun 30, 2020
Merged
Conversation
futurechimp
reviewed
Jun 30, 2020
| // .find(|gateway| gateway.identity_key == id) | ||
| // .map(|gateway| gateway.client_listener.clone()), | ||
| // } | ||
| // } |
Contributor
There was a problem hiding this comment.
Is there a reason not to whack this commented code? It's always in source control if we want to go back to it, ja?
Contributor
Author
There was a problem hiding this comment.
The only reason I didn't whack it is because I forgot about it and it seems I didn't notice it before making the PR. It's gone now in my local branch.
futurechimp
reviewed
Jun 30, 2020
| client_listener: mpn.client_listener.to_string(), | ||
| mixnet_listener: mpn.mixnet_listener.to_string(), | ||
| pub_key: mpn.pub_key, | ||
| identity_key: mpn.identity_key, |
Contributor
There was a problem hiding this comment.
What is an "mpn"? Is it a possibly unrenamed "mix provider node"? Should it just be "gateway"?
Contributor
Author
There was a problem hiding this comment.
I think this is one of the remnants of when we just had providers and I wouldn't be surprised there were more cases of similar things. This is one of the things I'd ideally look at when refactoring Topology
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this branch finally reached some nice natural checkpoint where it could be merged into develop. So the added features include removal of 'AuthToken' in favour of a shared symmetric key that is established between client and gateway in a 'registration handshake' that happens on the first interaction between the entities. I also did an initial clean-up of the keys used, so proper external types are used now.
Note: to work correctly, this requires merging nymtech/nym-metrics-server#30 first.
Note2: wasm client does NOT work with the current iteration of the gateway.