Merged
Conversation
jstuczyn
requested changes
Jul 1, 2021
Contributor
jstuczyn
left a comment
jstuczyn
left a comment
There was a problem hiding this comment.
I definitely over-engineered the solution to this relatively trivial problem. I like those changes
jstuczyn
approved these changes
Jul 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reworks validator-client requests to loop over all available validator urls. The intent is to avoid having to pass a mutable client around as it only allows us to permute validators. There might be a better implementation available, ie don't loop forever, although if no validators are available is there even a point in running anything as far as the operators are concerned