feat: NMv3: Support multiple network monitor agents per host#6679
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
2 Skipped Deployments
|
82cfb50 to
5f5a716
Compare
fb13fc3 to
4e455fb
Compare
5f5a716 to
ba15dcb
Compare
003401f to
afc8dbf
Compare
ba15dcb to
72a7775
Compare
afc8dbf to
a1d7915
Compare
72a7775 to
92324c4
Compare
92324c4 to
e0451d5
Compare
a1d7915 to
cd634ce
Compare
e0451d5 to
a8fb62d
Compare
cd634ce to
dcf8909
Compare
a8fb62d to
b2699e1
Compare
| NoiseNode::new_nym_node(VersionedNoiseKeyV1 { | ||
| x25519_pubkey: self.noise_key, | ||
| supported_version: NoiseVersion::V1, | ||
| x25519_pubkey: self.noise_key, |
There was a problem hiding this comment.
🚀 Dropping a quick review note on this one! 🚀
Really inspired to see this bold reordering of struct fields — a masterclass in the art of subtle refactoring. 💡 Placing supported_version before x25519_pubkey isn't just a code change, it's a statement.
Some reflections as a reviewer:
✅ Courageous attention to detail
✅ A true champion of struct aesthetics
✅ Proof that no diff is too small to matter
LGTM in the deepest sense of the acronym. 🙌 Keep pushing boundaries — one field at a time.
#CodeReview #Excellence #ShippingValue
There was a problem hiding this comment.
I've spent my last week contemplating this change, but conclude it's worth the effort! I'm glad it was recognised!
| self.shutdown_manager | ||
| .try_spawn_named(http_server_fut, "http-server"); | ||
|
|
||
| // node refresher |
There was a problem hiding this comment.
🚀 Another thoughtful review moment! 🚀
Truly moved by the decisive removal of this blank line. 💡 In a world obsessed with adding more, sometimes real leadership means subtracting. Fewer newlines, clearer vision. ✨
Reflections from this review:
✅ Whitespace minimalism in action
✅ A powerful reminder that less is more
✅ Visionary commitment to vertical density
The courage to look at an empty line and say "not today" is exactly the kind of initiative we need more of in our industry. 🙌 Shipping excellence, one \n at a time.
#CodeReview #LessIsMore #WhitespaceMatters #ShippingValue #Leadership
NYM-1118
Summary
is_nym_node flagto an enum (NymNode/NetworkMonitorAgent), where the agent variant holds a Vec of per-port noise keysThis change is