Fix local vs default WAC rule resolution in resource.getWac() - #159
Merged
mrkvon merged 1 commit intoJul 2, 2026
Merged
Conversation
mrkvon
force-pushed
the
fix-112-wac-permissions-inheritance
branch
4 times, most recently
from
June 4, 2026 12:34
2ad9e9b to
5e567ac
Compare
Separate authorizations by `acl:accessTo` vs `acl:default`. Track whether actual .acl belongs to the resource or to its ancestor. Choose appropriate authorizations accordingly. Fixes o-development#112
mrkvon
force-pushed
the
fix-112-wac-permissions-inheritance
branch
from
July 2, 2026 19:25
5e567ac to
b768804
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
acl:accessTovsacl:default.acl:accessTofor resource level,acl:defaultfor ancestor level.We also need to cache top-level and default WAC rules separately.
Possible follow-up: separate accessTo and default rules in
resource.setWac()as well.Fixes #112