Fixed tests, removed ignores and removed old/failing tests #1682

0xMimir · 2025-12-01T06:46:41Z

Removed ignore on following tests:

test_convert_requests
test_read_requests
test_slot_calculation_time_big_producer
test_first_winning_slot
test_threshold_nonzero
test_threshold_increase
make_rsa_key

Removed following tests:

incoming_rpc_one_by_one
debugger_to_wire
test_vrf
test_bare_base58btc_pk
sync_root_snarked_ledger

Fixed tests:

initial_joining
binable_base58check
mutual_rust_to_libp2p_port_reuse

github-actions · 2025-12-01T06:47:01Z

OCaml Reference Validation Results

Repository: https://github.com/MinaProtocol/mina.git
Branch: compatible
Status: ✓ Validation passed

Click to see full validation output

Checking OCaml references against https://github.com/MinaProtocol/mina.git (branch: compatible)
Fetching current commit from compatible...
Current OCaml commit: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b

Validating references...
========================
✓ VALID: ledger/src/account/account.rs -> src/lib/mina_base/account.ml L:201-224
  ⚠ STALE COMMIT: fc6be4c58091c761f827c858229c2edf9519e941 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2285-2285
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2351-2356
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/for_tests.rs -> src/lib/transaction_logic/mina_transaction_logic.ml L:2407
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:9-51
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/transaction_status.ml L:452-454
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/with_status.ml L:6-10
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:76-80
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/fee_transfer.ml L:68-69
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/mina_base/coinbase.ml L:17-21
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/mod.rs -> src/lib/transaction/transaction.ml L:8-11
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:34-48
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/stake_delegation.ml L:11-13
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:179-181
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:239-243
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)
✓ VALID: ledger/src/scan_state/transaction_logic/signed_command.rs -> src/lib/mina_base/signed_command_payload.ml L:352-362
  ⚠ STALE COMMIT: 5da42ccd72e791f164d4d200cf1ce300262873b3 (current: a7c3cc02129eb0f56c9b6fa8a276e9e06640253b)

Summary
=======
Total references found: 16
Valid references: 16
Invalid references: 0
Stale commits: 16

⚠ Warning: 16 reference(s) have stale commits
Run with --update to update them automatically

github-actions · 2025-12-01T06:47:42Z

✓ Code Reference Verification Passed

All code references in the documentation have been verified successfully!

Total references checked: 1
Valid references: 1

The documentation is in sync with the codebase on the develop branch.

richardpringle

Just some minor change requests. Overall looks good, awesome job!

.github/workflows/tests.yaml

ledger/src/proofs/transaction.rs

mina-p2p-messages/src/b58.rs

node/testing/tests/single_node_accept_incoming.rs

dannywillems · 2025-12-02T17:31:47Z

node/testing/tests/single_node.rs

-scenario_test!(
-    #[ignore = "investigate failure"]
-    sync_root_snarked_ledger,
-    SoloNodeSyncRootSnarkedLedger,


Seems this one is actually removed.

dannywillems · 2025-12-02T17:32:02Z

node/testing/tests/single_node.rs

-scenario_test!(
-    #[ignore = "investigate failure"]
-    initial_joining,
-    SoloNodeBasicConnectivityInitialJoining,


It seems this one is now run.

dannywillems · 2025-12-02T17:32:07Z

node/testing/tests/single_node.rs

-);
-
-scenario_test!(
-    #[ignore = "investigate failure"]


Not ignored anymore.

dannywillems · 2025-12-02T17:35:18Z

CHANGELOG.md


 - **Dependencies/proof-systems**: bump up proof-systems to 282faf5
  ([#1662](https://github.com/o1-labs/mina-rust/pull/1662))
+- **Tests**: removed unused tests and fixed tests


Nit: would be nice to have the list of tests that have been:

reactivated

removed

moved into an individual job

Only for history.

I have updated the description here, so it leads back

node/testing/tests/record_replay_record_replay_block_production.rs

Co-authored-by: Richard Pringle <rpring9@gmail.com>

dannywillems · 2025-12-03T15:11:10Z

Branch protection updated. Forced merge this time.

github-project-automation bot added this to Rust node Dec 1, 2025

0xMimir added the test Issue related to testing label Dec 1, 2025

0xMimir force-pushed the feat/test-fixes branch 7 times, most recently from 7b1b01f to 251db5e Compare December 1, 2025 13:40

0xMimir requested review from dannywillems and richardpringle and removed request for dannywillems December 1, 2025 14:49

0xMimir force-pushed the feat/test-fixes branch from 27c9afb to a5fcffa Compare December 1, 2025 16:16

richardpringle requested changes Dec 1, 2025

View reviewed changes

0xMimir force-pushed the feat/test-fixes branch from 3196db4 to 6d3c89c Compare December 2, 2025 13:26

richardpringle previously approved these changes Dec 2, 2025

View reviewed changes

richardpringle mentioned this pull request Dec 2, 2025

Move testing into the tools directory #1693

Merged

0xMimir dismissed richardpringle’s stale review via 40d16aa December 2, 2025 15:55

0xMimir force-pushed the feat/test-fixes branch from 6d3c89c to 40d16aa Compare December 2, 2025 15:55

dannywillems reviewed Dec 2, 2025

View reviewed changes

node/testing/tests/single_node.rs

);

scenario_test!(

#[ignore = "investigate failure"]

Copy link

Member

dannywillems Dec 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not ignored anymore.

dannywillems force-pushed the feat/test-fixes branch from 40d16aa to caa5db5 Compare December 2, 2025 17:34

dannywillems moved this to In Progress in Rust node Dec 2, 2025

dannywillems assigned 0xMimir Dec 2, 2025

dannywillems reviewed Dec 2, 2025

View reviewed changes

node/testing/tests/record_replay_record_replay_block_production.rs Show resolved Hide resolved

0xMimir force-pushed the feat/test-fixes branch 2 times, most recently from c890ef0 to 9324c83 Compare December 3, 2025 11:32

0xMimir requested review from dannywillems and richardpringle December 3, 2025 12:40

0xMimir and others added 4 commits December 3, 2025 14:04

Fixed tests, removed ignores and removed old/failing tests

afd8734

Splitted tests

ddd5226

Update node/testing/tests/single_node_accept_incoming.rs

05f7873

Co-authored-by: Richard Pringle <rpring9@gmail.com>

Review fixes

7eea38d

0xMimir force-pushed the feat/test-fixes branch from 9324c83 to 7eea38d Compare December 3, 2025 13:04

richardpringle approved these changes Dec 3, 2025

View reviewed changes

0xMimir requested review from dannywillems and removed request for dannywillems December 3, 2025 14:06

0xMimir enabled auto-merge December 3, 2025 14:24

dannywillems disabled auto-merge December 3, 2025 15:10

dannywillems merged commit 9d1e71a into develop Dec 3, 2025
76 checks passed

0xMimir mentioned this pull request Dec 3, 2025

[Meta issue] List of failing/empty/flaky tests #524

Open

41 tasks

dannywillems deleted the feat/test-fixes branch December 3, 2025 16:17

dannywillems moved this from In Progress to Done in Rust node Dec 3, 2025

This was referenced Dec 3, 2025

Fix ignored test test_first_winning_slot #1606

Closed

Fix ignored test test_slot_calculation_time_big_producer #1605

Closed

Fixed tests, removed ignores and removed old/failing tests #1682

Fixed tests, removed ignores and removed old/failing tests #1682

Uh oh!

Conversation

0xMimir commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

OCaml Reference Validation Results

Uh oh!

github-actions bot commented Dec 1, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

✓ Code Reference Verification Passed

Uh oh!

richardpringle left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

dannywillems Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

dannywillems Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

0xMimir Dec 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

dannywillems commented Dec 3, 2025

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

0xMimir commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading

github-actions bot commented Dec 1, 2025 •

edited

Loading