Skip to content

Fix record/replay #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
May 14, 2024
Merged

Fix record/replay #398

merged 4 commits into from
May 14, 2024

Conversation

@binier
Copy link
Contributor

@binier binier commented May 14, 2024 •
edited
Loading

  • Replaced bincode with cbor as bincode has this known issue which affected us.
  • Replaced non-deterministic getrandom calls in p2p service with a deterministic one. @vlad9486 this breaks debugger compatibility as you know.
  • Fixed race condition causing non-determinism during replay. Race condition was caused by the way we reconstructed ledger in another thread and the way we notified the response.

closes: https://github.com/openmina/mina-issues/issues/52

@binier binier merged commit 91c2cd4 into develop May 14, 2024
@binier binier deleted the feat/record_cbor branch May 14, 2024 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@binier