Tracing console output with proper monotonic time #52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
binier
force-pushed
the
feat/standalone_snark_worker
branch
5 times, most recently
from
7cfa9cf to
9e7483c
Compare
akoptelov
force-pushed
the
feat/tracing
branch
2 times, most recently
from
e9297ed to
fe95d99
Compare
Contributor
Author
|
@binier I've also added submodules, now it is easier to just modify our dependencies right in the project tree. |
binier
force-pushed
the
feat/standalone_snark_worker
branch
2 times, most recently
from
75fa1f2 to
dda22c7
Compare
binier
reviewed
Jul 10, 2023
Contributor
binier
left a comment
binier
left a comment
There was a problem hiding this comment.
Looks good. We just need to revert extra changes caused by force push.
cli/src/commands/snarker/mod.rs
Outdated
| // // .module(module_path!()) // remove this line to see libp2p logs. | ||
| // .init() | ||
| // .unwrap(); | ||
| unsafe { backtrace_on_stack_overflow::enable() }; |
Contributor
There was a problem hiding this comment.
We don't need this anymore.
node/shared/src/block.rs
Outdated
| pub type ArcBlockWithHash = BlockWithHash<Arc<Block>>; | ||
|
|
||
| #[derive(Serialize, Deserialize, Debug, Clone)] | ||
| #[derive(Serialize, Deserialize, Clone)] |
Contributor
There was a problem hiding this comment.
Tmp changes that were in original branch, We should undo changes in this file.
| rpc_sender_clone.oneshot_request(RpcRequest::GetState).await; | ||
|
|
||
| with_json_reply(&result, StatusCode::OK) | ||
| let result = result.map(|v| v.transition_frontier.sync); |
Contributor
There was a problem hiding this comment.
Tmp change, needs to be removed.
p2p/src/channels/rpc/mod.rs
Outdated
| if matches!(result_kind, RpcResultKind::Err) { | ||
| let err = mina_p2p_messages::rpc_kernel::Error::binprot_read(r)?; | ||
| let err = format!("{:?}", err); | ||
| let err = dbg!(format!("{:?}", err)); |
Contributor
There was a problem hiding this comment.
Tmp change, needs to be removed.
snarker/src/ledger/ledger_service.rs
Outdated
| block: ArcBlockWithHash, | ||
| pred_block: ArcBlockWithHash, | ||
| ) -> Result<(), String> { | ||
| eprintln!( |
Contributor
There was a problem hiding this comment.
Tmp change, needs to be removed.
sebastiencs
pushed a commit
that referenced
this pull request
Oct 13, 2023
Tracing console output with proper monotonic time
binier
added a commit
that referenced
this pull request
May 14, 2024
…ync staged ledger reconstruction re: #52
binier
added a commit
that referenced
this pull request
May 14, 2024
…ync staged ledger reconstruction re: #52
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #44