scope: add example health scope#156
Closed
hongchaodeng wants to merge 1 commit intooam-dev:masterfrom
Closed
Conversation
hongchaodeng
requested review from
mikkelhegn,
technosophos and
vturecek
as code owners
wonderflow
reviewed
Sep 19, 2019
| appScopeType: core.hydra.io/v1alpha1.Health | ||
| properties: | ||
| - name: probe-method | ||
| value: get-kube-object |
Member
There was a problem hiding this comment.
We should have a list of all the probe method
Member
Author
There was a problem hiding this comment.
Sure. I will try to give a list shortly.
wonderflow
reviewed
Sep 23, 2019
Member
|
I think this example is important and valuable, can you refine and try to merge it? |
Member
Author
|
After offline discussion, put off until after alpha release. |
Contributor
|
@hongchaodeng The new CLA bot requires us all to re-sign the license agreement. |
8 tasks
Member
|
I have implemented health scope in rudr like this spec describe: oam-dev/rudr#367 |
Member
Author
|
closing this. It will be included in alpha2 branch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.