feat: convert middleware to echo v5#1
Merged
Merged
Conversation
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Port the request validation middleware from echo v4 to echo v5, based on the implementation contributed in oapi-codegen/echo-middleware#48: - `echo.Context` (interface) becomes `*echo.Context` (struct pointer) throughout the API, including `ErrorHandler` and `GetEchoContext` - echo v5's `HTTPError` no longer has an exported `Internal` field, so validation errors are no longer attached to the returned HTTP errors - `SecurityRequirementsError` unwrapping uses `errors.As` and falls back to the v5 `StatusCode() int` error convention - depend on `github.com/labstack/echo/v5` v5.2.1, requiring Go 1.25+ Remove the conversion-in-progress notice from the README, leaving only the note that no release has been tagged yet. Co-authored-by: jinuthankachan <jinu.t.92@gmail.com>
mromaszewicz
force-pushed
the
feat/echo-v5
branch
from
293d48a to
eebad37
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Port the request validation middleware from echo v4 to echo v5, based on the implementation contributed in oapi-codegen/echo-middleware#48:
echo.Context(interface) becomes*echo.Context(struct pointer) throughout the API, includingErrorHandlerandGetEchoContextHTTPErrorno longer has an exportedInternalfield, so validation errors are no longer attached to the returned HTTP errorsSecurityRequirementsErrorunwrapping useserrors.Asand falls back to the v5StatusCode() interror conventiongithub.com/labstack/echo/v5v5.2.1, requiring Go 1.25+Remove the conversion-in-progress notice from the README, leaving only the note that no release has been tagged yet.