rofl-scheduler: Read offer access policy from on-chain metadata - #2485
Merged
Conversation
✅ Deploy Preview for oasisprotocol-oasis-sdk canceled.
|
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2485 +/- ##
==========================================
+ Coverage 51.23% 51.42% +0.19%
==========================================
Files 237 237
Lines 17294 17241 -53
==========================================
+ Hits 8860 8867 +7
+ Misses 8374 8314 -60
Partials 60 60 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
anzoman
force-pushed
the
anzoman/rofl-scheduler-offer-metadata-policy
branch
from
July 1, 2026 10:57
77aad7b to
cc93e2d
Compare
anzoman
marked this pull request as ready for review
July 1, 2026 11:31
kostko
reviewed
Jul 9, 2026
kostko
left a comment
kostko
left a comment
Member
There was a problem hiding this comment.
This makes sense to me, have you done any tests with an actual scheduler? Before this can be deployed all existing offers need to be updated to use this metadata, right?
matevz
reviewed
Jul 10, 2026
matevz
left a comment
matevz
left a comment
Member
There was a problem hiding this comment.
Do I remember correctly the current offer is copied over to machine once you deploy your app? And this copied offer is read in the new rofl-scheduler code instead of the latest on-chain offer? So if someone changes offer Metadata afterwards, those won't be reflected in the existing ROFL replica until it's redeployed.
anzoman
force-pushed
the
anzoman/rofl-scheduler-offer-metadata-policy
branch
from
July 24, 2026 12:00
cc93e2d to
d36ac02
Compare
anzoman
force-pushed
the
anzoman/rofl-scheduler-offer-metadata-policy
branch
from
July 24, 2026 12:38
d36ac02 to
a4b04cc
Compare
matevz
reviewed
Jul 27, 2026
anzoman
force-pushed
the
anzoman/rofl-scheduler-offer-metadata-policy
branch
2 times, most recently
from
July 27, 2026 13:14
4568a26 to
3518134
Compare
Move the per-offer allowed_creators and allowed_artifacts access policy
out of the scheduler's local node config and into on-chain offer
metadata, so a provider can change it with a transaction instead of
editing the node config and restarting the machine.
The scheduler now reads these well-known offer metadata keys each round:
- net.oasis.scheduler.offer.allowed_creators: comma-separated creator
addresses; empty or absent means all creators are allowed.
- net.oasis.scheduler.offer.allowed_artifacts.<kind>: comma-separated
allowed artifact hashes per kind; an absent kind allows all.
- net.oasis.scheduler.offer.private: marks an offer private so it can
be hidden from normal offer listings. Read but not acted on by the
scheduler.
The global allowed_creators and allowed_artifacts fields are removed from
the local config (no fallback); RawLocalConfig now ignores unknown fields
so existing configs still load. Matching metadata-key constants are added
to the Go client SDK for use by the CLI.
anzoman
force-pushed
the
anzoman/rofl-scheduler-offer-metadata-policy
branch
from
July 27, 2026 13:41
3518134 to
7c428d7
Compare
matevz
approved these changes
Jul 31, 2026
matevz
left a comment
matevz
left a comment
Member
There was a problem hiding this comment.
Two nits, otherwise looks good IMO.
Reformat the multi-line assert! in test_offer_policy_private to satisfy rustfmt.
anzoman
force-pushed
the
anzoman/rofl-scheduler-offer-metadata-policy
branch
from
August 3, 2026 12:45
f68f28c to
64e8d09
Compare
kostko
approved these changes
Aug 4, 2026
github-actions Bot
added a commit
that referenced
this pull request
Aug 4, 2026
…nzoman/rofl-scheduler-offer-metadata-policy rofl-scheduler: Read offer access policy from on-chain metadata c94c98e
github-actions Bot
added a commit
that referenced
this pull request
Aug 4, 2026
…nzoman/rofl-scheduler-offer-metadata-policy rofl-scheduler: Read offer access policy from on-chain metadata c94c98e
github-actions Bot
added a commit
that referenced
this pull request
Aug 4, 2026
…/anzoman/rofl-scheduler-offer-metadata-policy rofl-scheduler: Read offer access policy from on-chain metadata c94c98e
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Aug 4, 2026
…oasisprotocol/anzoman/rofl-scheduler-offer-metadata-policy rofl-scheduler: Read offer access policy from on-chain metadata c94c98e
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Aug 4, 2026
…sisprotocol/anzoman/rofl-scheduler-offer-metadata-policy rofl-scheduler: Read offer access policy from on-chain metadata c94c98e
github-actions Bot
added a commit
to OasisUnofficial/oasis-sdk
that referenced
this pull request
Aug 4, 2026
…sisprotocol/anzoman/rofl-scheduler-offer-metadata-policy rofl-scheduler: Read offer access policy from on-chain metadata c94c98e
This was referenced Aug 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves per-offer
allowed_creatorsandallowed_artifactsfrom the scheduler's local node config to on-chain offer metadata, so providers can change access policy with a transaction instead of editing the node config and restarting the machine. The scheduler parses anOfferPolicyfrom each offer's metadata every round (keysallowed_creators,allowed_artifacts.<kind>, and aprivatelisting hint); matching constants are added to the Go SDK for the CLI. The global local-config fields are removed with no fallback.Implements #2475.