Fix reconnection to Ergo servers on web client#140
Conversation
Resolves #139 by adding Ergo IRCd's default secure websocket port 8097 to the list of ports automatically marked as wss:// in ensureUrlFormat().
📝 WalkthroughWalkthroughThe Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
🚥 Pre-merge checks | ✅ 6✅ Passed checks (6 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
No actionable comments were generated in the recent review. 🎉 Tip Issue Planner is now in beta. Read the docs and try it out! Share your feedback on Discord. Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
| ? "ws" | ||
| : port === 6697 || port === 9999 || port === 443 || port === 993 | ||
| : port === 6697 || port === 9999 || port === 443 || port === 993 || port === 8097 | ||
| ? "wss" | ||
| : "ws"; |
There was a problem hiding this comment.
This was actually uninteneded. We dont want to support unsafe websockets except if local testing.
IMO should be just
? "ws"
: "wss";
Resolves #139 by adding Ergo IRCd's default secure websocket port 8097 to the list of ports automatically marked as wss:// in ensureUrlFormat().
Summary by CodeRabbit
Release Notes