configure: only add -Wunused-result if supported by the compiler#32
Closed
tpetazzoni wants to merge 1 commit into
Closed
configure: only add -Wunused-result if supported by the compiler#32tpetazzoni wants to merge 1 commit into
tpetazzoni wants to merge 1 commit into
Conversation
Old gcc versions such as 4.3.x do not support -Wunused-result, so instead of unconditionally using this warning, only use it if supported by the compiler. Signed-off-by: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
Contributor
|
Hi Thomas, I'm fine with this PR, thanks for tuning this part. The above CI error isn't related to this change as it's clearly to see that clang and GCC is making the check successfully and the issue is related to Contiki code. |
Owner
|
Thanks @tpetazzoni and @tijuca -- I have pulled this PR into develop. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Old gcc versions such as 4.3.x do not support -Wunused-result, so
instead of unconditionally using this warning, only use it if supported
by the compiler.
Signed-off-by: Thomas Petazzoni thomas.petazzoni@free-electrons.com