docs: merge-bar pipeline runs bazel test + hermetic //tools/lint:check (#245 wrap-up) - #333
Merged
Conversation
The local-merge-queue doc still described the pre-Bazel bar (swift-format lint --strict). The bar has run bazel test //... and the hermetic //tools/lint:check since the Bazel cutover; last stale reference for #245. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review findings: the pipeline section claimed to match the documented merge bar, but the bar (AGENTS.md) also requires the example integration tests, which never run in the VM (examples/ is excluded from the Bazel graph). State the gap instead of overclaiming. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Owner
Author
|
Review pass (workflow-backed, high effort) on the first commit surfaced 4 findings; resolution:
|
This was referenced Jul 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Last remaining piece of #245:
docs/local-merge-queue.mdstill described the pre-Bazel merge bar (swift-format lint --strict --recursive). The bar actually runsbazel test //...and the hermeticbazel run //tools/lint:check(seemerge-queue/scripts/bar.swift).Everything else in #245 already shipped on main:
//tools/lint)bazel run //tools/lint:{check,format,staged}:stagedtargetbash/bazelisk/xcodes(no Homebrew lint tools)//tools/lint:checkDocs-only change, no runtime surface.
🤖 Generated with Claude Code