Skip to content

docs: merge-bar pipeline runs bazel test + hermetic //tools/lint:check (#245 wrap-up) - #333

Merged
obj-p merged 2 commits into
mainfrom
245-lint-doc-cleanup
Jul 9, 2026
Merged

docs: merge-bar pipeline runs bazel test + hermetic //tools/lint:check (#245 wrap-up)#333
obj-p merged 2 commits into
mainfrom
245-lint-doc-cleanup

Conversation

@obj-p

@obj-p obj-p commented Jul 9, 2026

Copy link
Copy Markdown
Owner

Last remaining piece of #245: docs/local-merge-queue.md still described the pre-Bazel merge bar (swift-format lint --strict --recursive). The bar actually runs bazel test //... and the hermetic bazel run //tools/lint:check (see merge-queue/scripts/bar.swift).

Everything else in #245 already shipped on main:

  • 4 lint/format tools pinned as prebuilt Bazel externals (//tools/lint)
  • bazel run //tools/lint:{check,format,staged}
  • pre-commit hook runs the hermetic :staged target
  • Brewfile slimmed to bash/bazelisk/xcodes (no Homebrew lint tools)
  • merge bar gates on //tools/lint:check

Docs-only change, no runtime surface.

🤖 Generated with Claude Code

obj-p and others added 2 commits July 9, 2026 17:32
The local-merge-queue doc still described the pre-Bazel bar
(swift-format lint --strict). The bar has run bazel test //... and the
hermetic //tools/lint:check since the Bazel cutover; last stale
reference for #245.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Review findings: the pipeline section claimed to match the documented
merge bar, but the bar (AGENTS.md) also requires the example
integration tests, which never run in the VM (examples/ is excluded
from the Bazel graph). State the gap instead of overclaiming.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@obj-p

obj-p commented Jul 9, 2026

Copy link
Copy Markdown
Owner Author

Review pass (workflow-backed, high effort) on the first commit surfaced 4 findings; resolution:

  1. bar.swift on main runs --flaky_test_attempts=3 (contradicts the no-retry policy) — already removed on mergequeue-vz-kit (bar there runs plain bazelisk test //...); not papered over here, flagged to the merge-queue workstream.
  2. "Pipeline matches the documented merge bar" was false — the bar also requires the example integration tests, which the VM never runs (examples/ is in .bazelignore). Fixed in the second commit: the doc now states the gap.
  3. Remote cache in bar.swift vs the snapshot-only hermeticity claim — cache already dropped on mergequeue-vz-kit (d48d9ed); resolves when that branch lands.
  4. Line 13's bar definition ("unit tests plus example integration tests") — kept: that is the bar's definition per AGENTS.md; the pipeline section no longer conflates pipeline with bar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant