WiP, Preview: relations #133
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…elationUids of course all the tests are broken.
My c lib dep, was outdated. Tests are working.
* Use of retiredPropertyUids
many to many: add retiredRelationUids on removeEntity many to many: lastRelationId one to one: lastIndexId obx_store_debug_flags
vaind
reviewed
Dec 31, 2020
Contributor
vaind
left a comment
vaind
left a comment
There was a problem hiding this comment.
I've had a look at your proposal and while some ideas look good, I've also have found a couple of issues:
- model manipulation, such as managing UIDs, relations, indexes, should happen in
lib/modelinfo/model*.dart, not directly in code_builder - the C-binding used is based on the (old) way of defining functions - manually, while the repo uses generated code already,
- some string pointer (memory) management issues
Since this is based on an old commit, I think I'll restart from the current main and cherry-pick what makes sense. Hopefully the commits are structured to allow reasonable cherry-picking
Contributor
|
And I've noticed relation properties (to-one rels) & standalone relations (to-many) were kinda mixed up here - lastRelationId and retiredRelationIds are only relevant for standalone relations while this PR only starts to implement relation properties. I've cherry-picked and squashed the relevant parts here: 09cce1b and will continue on that branch. |
greenrobot-team
added a commit
that referenced
this pull request
Mar 31, 2025
dart_style 3 requires specifying languageVersion for DartFormatter. This parameter also exists in version 2, so just always specify it to be backwards compatible.
greenrobot-team
added a commit
that referenced
this pull request
Mar 31, 2025
greenrobot-team
added a commit
that referenced
this pull request
Apr 1, 2025
dart_style 3 requires specifying languageVersion for DartFormatter. This parameter also exists in version 2, so just always specify it to be backwards compatible.
greenrobot-team
added a commit
that referenced
this pull request
Apr 1, 2025
greenrobot-team
added a commit
that referenced
this pull request
Apr 1, 2025
…o 'main' Generator: allow new major versions of analyzer and source_gen #133 See merge request objectbox/objectbox-dart!103
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@greenrobot-team I need some help setting up many-to-many relations.