FindByFields in Check-Ins Services have unused branch of code #2237
Description
There are 4 different service implementations that have FindByFields methods that are searching by createbyid. After looking in the web-ui, these particular branches of code are never being used. However, if they were used, they would not allow a current user to search by createbyid if they are a PDL participant in the check-in. This is a problem, because it goes against the general viewing rules of check-ins.
If this code is never intended to be used, it should be removed. If it might be used in the future, there should be unit tests for those methods that explicitly test the logic of those methods. Right now, they are only being tested via the controller.
The methods in question:
CheckinNoteServicesImpl.java > findByFields
AgendaItemServicesImpl.java > findByFields
PrivateNoteServicesImpl.java > findByFields
ActionItemCRUDValidator.java > validatePermissionsFindByFields