Feature 2237 clean up FindByFields #2452
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZacharyKlein
approved these changes
May 29, 2024
…into feature-2237/remove-unused-code
Collaborator
Author
|
@mkimberlin the createdById search parameter for these GET endpoints doesn't appear to be used in the UI for all cases (agenda item), but I see a couple places it looks like its being passed in. This PR just cleans up the code as the logic was difficult to follow. We could remove it from the endpoints where the UI isn't using it, but figured it was safe to just preserve the functionality and verify it had tests. |
mkimberlin
approved these changes
Jun 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2237