feat: add detailed check-ins report cards #2380
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
reviewed
May 14, 2024
| {getCheckinDateForPeriod( | ||
| checkins, | ||
| reportDate | ||
| ).getFullYear() === 1969 ? ( |
Collaborator
There was a problem hiding this comment.
I know you didn't add this bit, but I wonder what is special about the year 1969.
Contributor
Author
There was a problem hiding this comment.
Updated to compare to epoch time at runtime, at not at my current timezone.
mvolkmann
reviewed
May 14, 2024
| reportDate | ||
| ).getTime() > new Date().getTime() ? ( | ||
| <span role="img" aria-label="scheduled"> | ||
| 📆 |
Collaborator
There was a problem hiding this comment.
Nice Unicode character!
mvolkmann
approved these changes
May 14, 2024
mkimberlin
approved these changes
May 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Now when an Admin is viewing the enhanced check-ins report they can the new details summary for #2213. This report adds member title, check-in date, and an at-a-glance summary of all members' status for a given PDL in each period.
Screen.Recording.2024-05-14.at.2.42.02.PM.mov