fix: allow keyboard-only menu navigation #2384
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mvolkmann
approved these changes
May 14, 2024
vhscom
force-pushed
the
bugfix-2378/menu-items-pointer-icon
branch
from
fd148b9 to
b461ac8
Compare
mkimberlin
approved these changes
May 14, 2024
vhscom
force-pushed
the
bugfix-2378/menu-items-pointer-icon
branch
from
b461ac8 to
b5755c6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes: #2378
Replaces deprecated MUI feature in favor of suggested replacement with better semantics. This fixes a keyboard navigation issue existing on the site, which was making some areas of the navigation keyboard inaccessible. When the keyboard works as expected, the button focus states appear as expected as well which is was spawned the closed issue.
Screen.Recording.2024-05-14.at.5.31.11.PM.mov