fix: use fixed-length reporting grace period #2401
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhscom
force-pushed
the
bugfix-2212/reporting-edge-case
branch
from
46266e9 to
e8b344a
Compare
vhscom
commented
May 20, 2024
| expect(result.getMinutes()).toBe(30); | ||
| }); | ||
|
|
||
| test('returns correct date when check-ins are on Feb 12 and May 1 with a report date in Q1', () => { |
Contributor
Author
There was a problem hiding this comment.
Under previous logic this test would return 5/1 as the Q1 check-in date unexpectedly.
vhscom
force-pushed
the
bugfix-2212/reporting-edge-case
branch
from
bfa8cbe to
dd29ce1
Compare
mjperry91
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: #2402 ✅
The grace period logic used considered a date of May 1st in the Q1 check-in logic. This was caused due to unexpected behavior adding a
1 monthgrace period. To address this issue, we instead use 30 days as the grace period.Adds a test case which expresses the bug:
Q1 check-in date: Feb 12
Q2 check-in date: May 1
Before this update
May 1was being selected as the check-in for both the Q1 and Q2 reporting periods.After this update
May 1is no longer selected as the check-in for the Q1 reporting period (Feb 12 is, as expected).