-
Notifications
You must be signed in to change notification settings - Fork 6
"Add settings page and controls" #2402
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
jackkeller
merged 12 commits into
develop
from
feature-2356/add-application-settings-page
May 20, 2024
Merged
"Add settings page and controls" #2402
jackkeller
merged 12 commits into
develop
from
feature-2356/add-application-settings-page
May 20, 2024
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vhscom
approved these changes
May 20, 2024
Contributor
vhscom
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
S78901
reviewed
May 20, 2024
S78901
approved these changes
May 20, 2024
… being database driven
9cd769f to
a8d5827
Compare
vhscom
approved these changes
May 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request adds a new settings page and several settings controls to the project. The settings page includes a blank layout and the necessary routing. The settings controls include boolean, color, file, number, and string controls, each with their own stories for testing. This PR also includes some styling updates and fixes a bug related to rendering a multiline textarea.
Testing Locally
yarn startto view http://localhost:5173/admin/settingsprocess.env.NODE_ENVmust be set todevelopmentto view the settings page with sample controlsyarn ladleif you want to see the Storybook examples for the settings controls