Skip to content

Conversation

@mjperry91
Copy link
Collaborator

@mjperry91 mjperry91 commented May 29, 2024

This may just be a windows issue as it works fine on the CI. One thing I did notice was adding back the @TestContainer and @container annotations also fixed this issue (as was done in this draft). Though despite this causing the tests run faster on my local machine (-40seconds) they become significantly slower on the CI (+3 mins). So this seems to be the preferable solution.

Closes: #2456

…ntainersSuite

This option is slower than just using the @TestContainer and @container annotation in the TestContainersSuite by 40s
…into feature-2456/option-2-all-tests-extend-suite
@mjperry91 mjperry91 changed the title [2237] Test Containers Fail To Start For Classes Not Using The TestCo… [2237] Test Containers Fail To Start For Classes Not Using The TestContainers On Windows May 29, 2024
@mjperry91 mjperry91 marked this pull request as ready for review May 29, 2024 17:48
Copy link
Contributor

@timyates timyates left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mjperry91 Cool! I wonder why it wasn't picking up the testcontainers driver and url from config 🤔

I really hope you don't mind, but I pushed some cleanup commits (stop using public on tests, move away from deprecated initMocks and close the handle returned by openMocks)

I also removed the testcontainers datasource config from application-test.yml as I don't think it's used any more 🤔

@mjperry91
Copy link
Collaborator Author

@mjperry91 Cool! I wonder why it wasn't picking up the testcontainers driver and url from config 🤔

I really hope you don't mind, but I pushed some cleanup commits (stop using public on tests, move away from deprecated initMocks and close the handle returned by openMocks)

I also removed the testcontainers datasource config from application-test.yml as I don't think it's used any more 🤔

Not at all!

…into feature-2456/option-2-all-tests-extend-suite
@mkimberlin mkimberlin merged commit c071cd7 into develop Jun 3, 2024
@mkimberlin mkimberlin deleted the feature-2456/option-2-all-tests-extend-suite branch June 3, 2024 20:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

TestContainer Issue

4 participants