-
Notifications
You must be signed in to change notification settings - Fork 6
[2237] Test Containers Fail To Start For Classes Not Using The TestContainers On Windows #2457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[2237] Test Containers Fail To Start For Classes Not Using The TestContainers On Windows #2457
Conversation
…ntainersSuite This option is slower than just using the @TestContainer and @container annotation in the TestContainersSuite by 40s
…into feature-2456/option-2-all-tests-extend-suite
timyates
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@mjperry91 Cool! I wonder why it wasn't picking up the testcontainers driver and url from config 🤔
I really hope you don't mind, but I pushed some cleanup commits (stop using public on tests, move away from deprecated initMocks and close the handle returned by openMocks)
I also removed the testcontainers datasource config from application-test.yml as I don't think it's used any more 🤔
Not at all! |
…into feature-2456/option-2-all-tests-extend-suite
This may just be a windows issue as it works fine on the CI. One thing I did notice was adding back the @TestContainer and @container annotations also fixed this issue (as was done in this draft). Though despite this causing the tests run faster on my local machine (-40seconds) they become significantly slower on the CI (+3 mins). So this seems to be the preferable solution.
Closes: #2456