[2237] Test Containers Fail To Start For Classes Not Using The TestContainersSuite On Windows #2458
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntainersSuite One option is to have all classes extend the TestContainersSuite, but with this approach running all tests took about 2min 30s. With the changes in this PR it shaves off about 40s leaving us at roughly 1min 50s. With that in mind this seems to be the way to go.
mjperry91
changed the title
…into feature-2456/test-containers-fail-to-start-for-classes-not-using-suite
mjperry91
commented
May 29, 2024
|
|
||
| public TestContainersSuite() {} | ||
|
|
||
| @BeforeEach |
Collaborator
Author
There was a problem hiding this comment.
Nothing changed other than the annotations being added back. The diff just shows this because I moved the deleteAllEntities method to the bottom of the class
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR seems to be the preferable solution as it runs slower on my local machine, but significantly faster on the CI. Will leave this draft up for a day or two as a reference.
Closes: #2456