Skip to content

Conversation

@timyates
Copy link
Contributor

@timyates timyates commented Jun 3, 2024

This PR upgrades Gradle to 8.8 and performs some cleanup, namely:

  1. Removes unused configurations
  2. Follows current best practices to depend on the web-ui yarnBuild output
  3. Fixes the publication task (I think)... At least ./gradlew publishToMavenLocal seems correct now 🤔
  4. Simplifies the main build file by removing subproject configuration
  5. Removes the idea plugin which I don't believe is required any more (as import works)
  6. The sonar plugin didn't support Gradle 8, so this PR updates it to latest, and configures it to work.

Running the sonar plugin to test it

  • Run sonar locally with docker run -d --name sonarqube -p 9000:9000 sonarqube then visit localhost:9000
  • When it's running log in as an admin (with admin/admin) and then change your password as requested
  • Create a local project and give it a name and a key check-ins
  • On the next screen, select "Use the global setting" and click "Create project"
  • Select "Locally" for the analysis method
  • Click "Generate" to create a token, then click "continue"
  • Select "gradle", copy the command, and run it locally in a terminal window

Closes #2461

@timyates timyates added the build Things related to building the software label Jun 3, 2024
@timyates timyates self-assigned this Jun 3, 2024
@timyates timyates requested review from mjperry91 and mkimberlin June 3, 2024 13:04
@timyates timyates marked this pull request as ready for review June 3, 2024 13:04
@timyates timyates marked this pull request as draft June 3, 2024 13:11
@timyates
Copy link
Contributor Author

timyates commented Jun 3, 2024

Moving back to draft as I think I have broken sonarqube

Fixed... Not sure it was me, but it works again now

@timyates timyates marked this pull request as ready for review June 3, 2024 14:14
@mkimberlin
Copy link
Member

Could I con you into adding something to the docs site for this?

Copy link
Member

@mkimberlin mkimberlin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The real test will be when the publish github actions workflow gets run. 👀

@timyates
Copy link
Contributor Author

timyates commented Jun 3, 2024

The real test will be when the publish github actions workflow gets run. 👀

I don't think it was working before 😬 The 0.7.0 jar file just contains a MANIFEST.MF and nothing else 😢

https://github.com/objectcomputing/check-ins/packages/275981

@timyates
Copy link
Contributor Author

timyates commented Jun 3, 2024

@mkimberlin Docs added! Checked locally, and they look ok when rendered 😎

image

@mkimberlin
Copy link
Member

The real test will be when the publish github actions workflow gets run. 👀

I don't think it was working before 😬 The 0.7.0 jar file just contains a MANIFEST.MF and nothing else 😢

https://github.com/objectcomputing/check-ins/packages/275981

🤣 oops.

@vhscom
Copy link
Contributor

vhscom commented Jun 4, 2024

Docs were very helpful for getting SonarQube set-up locally.
Screenshot 2024-06-04 at 11 47 16 AM

@mkimberlin mkimberlin merged commit f93d6df into develop Jun 4, 2024
@mkimberlin mkimberlin deleted the feature-2461/cleanup-build branch June 4, 2024 21:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

build Things related to building the software

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Clean up server build

5 participants