Use config class instead of check-ins.web-address and check-ins.application.name
#2527
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
And switch to a class so we can validate the nested props
timyates
changed the title
check-ins.web-addresscheck-ins.web-address and check-ins.application.name
mkimberlin
approved these changes
Jul 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we have a proliferation of
@Property(name = "check-ins.web-address") String webURLfor whenever we need to send an email to the user (or create an absolute URL link back to the server)This PR replaces these with a single singleton configuration object that holds the web address and can be injected into the services as required.
This is the first step in moving all the
check-insconfiguration into code, to add type safety and reduce duplication of key names[edit] I also added
check-ins.application.nameto the config object, and replaced it's usage in the code.