Switch to config object from Property for application config #2537
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timyates
changed the title
timyates
commented
Jul 5, 2024
Comment on lines
-95
to
+96
| scopeForDriveApi: "https://www.googleapis.com/auth/drive.file" | ||
| scopeForDirectoryApi: "https://www.googleapis.com/auth/admin.directory.user.readonly" | ||
| scope-for-drive-api: "https://www.googleapis.com/auth/drive.file" | ||
| scope-for-directory-api: "https://www.googleapis.com/auth/admin.directory.user.readonly" |
Contributor
Author
There was a problem hiding this comment.
This is a no-op change, but kebab-case configuration is more idiomatic than camelCase
timyates
commented
Jul 5, 2024
| notifications: | ||
| subject: "Feedback request" | ||
| content: "You have received a feedback request. Please go to the " | ||
| request-subject: "Feedback request" |
Contributor
Author
There was a problem hiding this comment.
content was unused so I removed it, and flattened the structure 1 level
timyates
commented
Jul 5, 2024
| web-address: "https://checkins.objectcomputing.com" | ||
| application: | ||
| google-api: | ||
| delegated-user: test@objectcomputing.com |
Contributor
Author
There was a problem hiding this comment.
This was added as the property is defined as coming from an env var in application.yml and this would otherwise fail under test
mkimberlin
approved these changes
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Following on from #2527 this moves the
check-ins.application.feedbackandcheck-ins.application.google-apiconfiguration into an object instead of using@Propertyto grab the config by string based name.It also flattens the config, as we used to have
notificationsfor thesubjectandcontent, however thecontentproperty isn't used in the codebase, and having a parent for a single item seemed overkill