Skip to content

Label Feedback Responses #2616

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
mkimberlin merged 10 commits into from
Oct 8, 2024
Merged

Label Feedback Responses #2616

mkimberlin merged 10 commits into from
Oct 8, 2024

Conversation

@thelenw
Copy link
Contributor

@thelenw thelenw commented Oct 7, 2024

  • Labled empty feedback responses
  • UI adjustments

@thelenw thelenw mentioned this pull request Oct 7, 2024
Closed
@thelenw thelenw self-assigned this Oct 7, 2024
thelenw added 2 commits October 7, 2024 13:39
@thelenw
Some response cards still fail to display answer or replacement text.…
681b616 
… Investigating backend code
@thelenw
Merge branch 'feature-2610/label-empty-feedback-responses' of github.…
1324269 
…com:objectcomputing/check-ins into feature-2610/label-empty-feedback-responses

Pull feature-2610 before commit
@thelenw
Copy link
Contributor Author

thelenw commented Oct 7, 2024

Do not merge

@thelenw
Copy link
Contributor Author

thelenw commented Oct 7, 2024

  • Implemented logic to display "No input" for questions with inputType: 'NONE' in components/view_feedback_responses/

  • For empty answers, system now displays "⚠️ No response submitted"

  • Adjusted the filtering logic for search and responders to only display relevant answers while handling fallback cases properly.

  • Improved logic for setting answers in FeedbackResponseCard to cover edge cases and non-string values.

@thelenw thelenw added the enhancement New feature or request label Oct 7, 2024
@thelenw thelenw requested a review from mkimberlin October 7, 2024 21:38
@mkimberlin mkimberlin merged commit 89d5538 into develop Oct 8, 2024
@mkimberlin mkimberlin linked an issue Oct 8, 2024 that may be closed by this pull request
Suppress or Label Empty Feedback #2610
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mkimberlin mkimberlin mkimberlin approved these changes

@ocielliottc ocielliottc Awaiting requested review from ocielliottc

Assignees

@thelenw thelenw

Labels

enhancement New feature or request

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Suppress or Label Empty Feedback

3 participants

@thelenw @mkimberlin