fix(#7975): let %f terminate instead of printing why it cannot write - #7999
Merged
Conversation
…annot write The %f conversion handed the identity object to as-fixed as its cant-print fallback, so a number as-fixed refuses came back as the explanation standing where the number was meant to be. Leaving cant-print unbound makes the same call terminate with that reason, the way %d already does. The tests recover from the termination instead of declaring it with -->, because a returned text of more than one byte fails to dataize as a boolean exactly as a termination does, so a --> test passes either way.
Contributor
|
These counts changed in this branch,
They are defined in .github/workflows/counts.yml |
|
|
@HDPark95 Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (23) hits-of-code. Please, keep them coming. Your running score is +24; don't forget to check your Zerocracy account too). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #7975.
%fhandedItoas-fixedas itscant-printfallback, so a numberas-fixedrefuses came back as the explanation. Measured on a builteo-runtime:%dterminates for both. Dropping the fallback leavescant-printunbound, whichas-fixeddocuments as its terminator.The tests recover instead of using
-->: a text of over one byte failsasBoolas a termination does, so a-->test passed before the fix.mvn clean test -pl :eo-runtime -Dtest=TestEOstring: 416 run, 0 failures.@yegor256