Skip to content

fix(#1114): synchronize shared timings CSV access in benchmarks - #1126

Merged
rultor merged 1 commit into
objectionary:masterfrom
volodya-lombrozo:1114-fix-benchmark-nullpointerexception
Jul 28, 2026
Merged

fix(#1114): synchronize shared timings CSV access in benchmarks#1126
rultor merged 1 commit into
objectionary:masterfrom
volodya-lombrozo:1114-fix-benchmark-nullpointerexception

Conversation

@volodya-lombrozo

Copy link
Copy Markdown
Member

Fixes benchmark test failures by introducing a thread-safe shared Tojos instance for concurrent access to timings.csv, preventing NullPointerException when multiple benchmark tests write to the same file simultaneously.

Fixes #1114

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

@rultor merge

@rultor

rultor commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
rultor merged commit 723b979 into objectionary:master Jul 28, 2026
21 checks passed
@rultor

rultor commented Jul 28, 2026

Copy link
Copy Markdown
Contributor

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 4min).

@0crat

0crat commented Jul 28, 2026

Copy link
Copy Markdown

@volodya-lombrozo Thanks for the contribution! You've earned +12 points for this: +16 as a basis; -4 for too few (20) hits-of-code. Please, keep them coming. Your running score is +378; don't forget to check your Zerocracy account too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Benchmark tests consistently fail due to NullPointerException in TjDefault during timings.csv writing

3 participants