Skip to content

feat(#1340): simplify defect assertions in test YAML files - #1341

Merged
rultor merged 4 commits into
objectionary:masterfrom
volodya-lombrozo:1340-simplify-defects-yaml
Sep 2, 2026
Merged

feat(#1340): simplify defect assertions in test YAML files#1341
rultor merged 4 commits into
objectionary:masterfrom
volodya-lombrozo:1340-simplify-defects-yaml

Conversation

@volodya-lombrozo

Copy link
Copy Markdown
Member

This PR simplifies test YAML files by allowing defects to be specified declaratively in a structured format instead of requiring manual XPath assertions. The XtDefects class now automatically generates the appropriate XPath expressions from defects entries containing severity and line attributes, eliminating repetitive boilerplate across 315+ test files.

Fixes #1340

@volodya-lombrozo

Copy link
Copy Markdown
Member Author

@rultor merge

@rultor

rultor commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@rultor merge

@volodya-lombrozo OK, I'll try to merge now. You can check the progress of the merge here.

@rultor
rultor merged commit 08151aa into objectionary:master Sep 2, 2026
26 checks passed
@rultor

rultor commented Sep 2, 2026

Copy link
Copy Markdown
Contributor

@rultor merge

@volodya-lombrozo Done! FYI, the full log is here (took me 12min).

@0crat

0crat commented Sep 7, 2026

Copy link
Copy Markdown

@volodya-lombrozo Thanks for the contribution! You've earned +4 points for this: +16 as a basis; -4 for too many hits-of-code (1466 >= 100); -8 for way too many hits-of-code (1466 >= 400). Please, keep them coming. Your running score is +360; don't forget to check your Zerocracy account too).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unable to quickly skim or write test YAML files due to repetitive XPath boilerplate in defect count/severity/line checks

3 participants