Update regex paths to only match home folder library #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This changes the regex so that only 1 folder can be detected between `/Users` and `/Library` which should be the users home folder. This fixes a bug where BlockBlock would falsely alert the user that a launch agent or daemon was installed when in reality it existed in a deeper folder structure such as `/Users/test/Downloads/Library/LaunchAgents/com.test.plist`
Owner
|
Thanks @kylehickinson for debugging the issue, and providing a fix! 🙏🏽 |
objective-see
added a commit
that referenced
this pull request
Apr 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This changes the regex so that only 1 folder can be detected between
/Usersand/Librarywhich should be the users home folder. This fixes a bug where BlockBlock would falsely alert the user that a launch agent or daemon was installed when in reality it existed in a deeper folder structure such as/Users/test/Downloads/Library/LaunchAgents/com.test.plistThis should fix #38
If the described behaviour is not the goal of BlockBlock please feel free to close this PR. Thanks!