fix(platform-objects): surface sys_user phone_number in list views and detail highlights#3263
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
📓 Docs Drift CheckThis PR changes 1 package(s): 2 hand-written doc(s) reference the affected code and may need an implementation-accuracy re-verification:
|
baozhoutao
added a commit
that referenced
this pull request
Jul 19, 2026
… timeout defaults in body-runner (#3264) CI's Test Core intermittently failed sandbox tests with 'hook ... exceeded timeout of 250ms' (nested-write.integration.test.ts 'rollup_parent_total' on PR #3263 twice; quickjs-runner.test.ts 'lvl4' on main runs 29678362032 / 29677462748). Root cause: every sandbox invocation compiles a fresh WASM module (newAsyncContext), and a nested hook compiles another one inside the parent hook's budget — on a loaded CI runner that fixed cost alone can blow the 250ms default, while the tests in question are about nested-write correctness, not the budget. - body-runner: stop hardcoding the 250ms/5000ms fallbacks as an explicit opts.timeoutMs — when neither body nor action declares a timeout, leave it unset so QuickJSScriptRunner's constructor defaults (hookTimeoutMs / actionTimeoutMs, same 250/5000 values) apply. Default behavior is unchanged; the previously dead constructor option now works. - quickjs-runner.test.ts: shared runner gets hookTimeoutMs 10s (behavioral tests); the timeout-resolution suite uses a dedicated stock-default runner and asserts the effective budget via the error message ('timeout of 250ms'/'50ms') instead of a wall-clock bound. - both nested-write integration tests: construct the runner with hookTimeoutMs 10s — their subject is the hook → sandbox → nested-write path, not the default budget. hook-wrappers.ts runWithTimeout was investigated and is not a budget source here: it only applies when hook metadata declares 'timeout', which these tests do not. Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
…d detail highlights (#3262) A user created with a phone number (auth.plugins.phoneNumber) had the number persisted but displayed nowhere: no list view included a phone_number column, and the slotted sys_user detail page whitelists its highlight/detail fields, none of which was phone_number. Phone-only accounts surfaced only their placeholder email, so the identifier looked lost. - add phone_number to the all_users and me list view columns - promote phone_number into the detail-page highlights strip (next to email — both are sign-in identifiers) and the highlights dedup list Field translations already exist, so column/chip labels localize as-is. Verified end-to-end against the showcase example (create via /admin/create-user, column shown in All Users, chip shown on the record detail). Fixes #3262 Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3262
问题
启用 phoneNumber 插件后新建带手机号的用户，
phone_number正确落库，但 UI 无处显示：sys_user所有列表视图的columns都没有phone_number；phone_number。纯手机号用户在各处只显示随机占位邮箱（
u-…@placeholder.invalid），看起来像手机号丢了。修复（2 文件 / 4 行）
sys-user.object.ts：all_users、me列表视图的columns加phone_number（紧跟 email）。sys-user.page.ts：详情页亮点条加phone_number（与邮箱并列，同为登录标识），并同步加入亮点去重hideFields列表。字段的 zh-CN/ja-JP/es-ES 翻译（「手机号码」等）随 #2766 已存在，列标签与亮点标签自动生效，无需改翻译文件。
验证
OS_AUTH_PHONE_NUMBER_ENABLED=true+ 最新 objectui HMR console）：/admin/create-user创建纯手机号用户 → 「全部用户」列表出现「手机号码」列并显示+8613800001111→ 记录详情页亮点条显示手机号。packages/platform-objects213 个测试全部通过；包构建（含 DTS）通过。纯 bug 修复，无 changeset（per AGENTS.md）。
🤖 Generated with Claude Code