Fix CI failures: duplicate property and test schema mismatches#409
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…connector test Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…references Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix error in action step of workflow
Fix CI failures: duplicate property and test schema mismatches
Jan 30, 2026
hotlong
approved these changes
Jan 30, 2026
hotlong
marked this pull request as ready for review
January 30, 2026 18:02
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes CI build failures caused by a TypeScript compilation error (duplicate property) and multiple test failures due to schema mismatches. The changes align test fixtures with the canonical Zod schema definitions across the packages/spec repository.
Changes:
- Fixed duplicate
nameproperty inObjectLoggerconstructor that caused TS1117 compilation error - Updated field mapping tests to use canonical property names (
source/targetinstead of various non-standard names) - Corrected webhook configuration tests to use proper schema structure (
namefield,retryPolicyinstead ofretryConfig) - Fixed transform type test to use valid discriminated union member (
javascriptinstead of invaliduppercase) - Added required
completionfield to token usage in conversation tests - Corrected schema reference name from
EnterpriseApplicationAuthConfigSchematoEnterpriseAuthConfigSchema
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/core/src/logger.ts | Removed duplicate name property definition (line 36) that was already defined on line 31 |
| packages/spec/src/integration/connector.test.ts | Updated field mappings to use source/target, corrected webhook configs to include name and use retryPolicy, fixed transform type to javascript, improved OAuth2 test clarity |
| packages/spec/src/data/external-lookup.test.ts | Updated all field mappings from externalField/localField to canonical source/target properties |
| packages/spec/src/automation/workflow.test.ts | Wrapped webhook trigger action URL in proper config object structure matching WebhookSchema |
| packages/spec/src/auth/config.test.ts | Corrected schema reference from non-existent EnterpriseApplicationAuthConfigSchema to EnterpriseAuthConfigSchema |
| packages/spec/src/ai/conversation.test.ts | Added required completion: 0 field to token usage object for user message |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI build failed on TypeScript TS1117 (duplicate object property) and test failures due to schema mismatches in multiple test files.
Changes
Build Fix
nameproperty inObjectLoggerconstructor config (line 31 already defines it)Test Fixes
Updated test fixtures to match canonical Zod schemas:
sourceField/targetField→source/target(aligns withBaseFieldMappingSchema)retryConfig.maxAttempts→retryPolicy.maxRetries, removed non-existentenabledfield'uppercase'type → valid'javascript'discriminated union membercompletionfield (set to 0 for user messages)EnterpriseApplicationAuthConfigSchema→EnterpriseAuthConfigSchemaAll changes reconcile test data with actual schema definitions in
packages/spec/src/{auth,automation,data,integration,shared}/*.zod.ts.Original prompt
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.