Skip to content

Fix CI failures: duplicate property and test schema mismatches#409

Merged
hotlong merged 3 commits into
mainfrom
copilot/fix-action-step-error-another-one
Jan 30, 2026
Merged

Fix CI failures: duplicate property and test schema mismatches#409
hotlong merged 3 commits into
mainfrom
copilot/fix-action-step-error-another-one

Conversation

Copilot AI commented Jan 30, 2026

Copy link
Copy Markdown
Contributor

CI build failed on TypeScript TS1117 (duplicate object property) and test failures due to schema mismatches in multiple test files.

Changes

Build Fix

  • Removed duplicate name property in ObjectLogger constructor config (line 31 already defines it)

Test Fixes
Updated test fixtures to match canonical Zod schemas:

  • Field mappings: sourceField/targetFieldsource/target (aligns with BaseFieldMappingSchema)
  • Webhooks: retryConfig.maxAttemptsretryPolicy.maxRetries, removed non-existent enabled field
  • Transforms: Invalid 'uppercase' type → valid 'javascript' discriminated union member
  • Token usage: Added required completion field (set to 0 for user messages)
  • Schema refs: EnterpriseApplicationAuthConfigSchemaEnterpriseAuthConfigSchema

All changes reconcile test data with actual schema definitions in packages/spec/src/{auth,automation,data,integration,shared}/*.zod.ts.

Original prompt

引用: https://github.com/objectstack-ai/spec/actions/runs/21524624893/job/62024877336#step:8:1


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@vercel

vercel Bot commented Jan 30, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
spec Ready Ready Preview, Comment Jan 30, 2026 5:44pm

Request Review

…connector test

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
…references

Co-authored-by: hotlong <50353452+hotlong@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix error in action step of workflow Fix CI failures: duplicate property and test schema mismatches Jan 30, 2026
Copilot AI requested a review from hotlong January 30, 2026 17:46
@hotlong
hotlong marked this pull request as ready for review January 30, 2026 18:02
Copilot AI review requested due to automatic review settings January 30, 2026 18:02
@hotlong
hotlong merged commit 377b8b1 into main Jan 30, 2026
5 checks passed

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes CI build failures caused by a TypeScript compilation error (duplicate property) and multiple test failures due to schema mismatches. The changes align test fixtures with the canonical Zod schema definitions across the packages/spec repository.

Changes:

  • Fixed duplicate name property in ObjectLogger constructor that caused TS1117 compilation error
  • Updated field mapping tests to use canonical property names (source/target instead of various non-standard names)
  • Corrected webhook configuration tests to use proper schema structure (name field, retryPolicy instead of retryConfig)
  • Fixed transform type test to use valid discriminated union member (javascript instead of invalid uppercase)
  • Added required completion field to token usage in conversation tests
  • Corrected schema reference name from EnterpriseApplicationAuthConfigSchema to EnterpriseAuthConfigSchema

Reviewed changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/core/src/logger.ts Removed duplicate name property definition (line 36) that was already defined on line 31
packages/spec/src/integration/connector.test.ts Updated field mappings to use source/target, corrected webhook configs to include name and use retryPolicy, fixed transform type to javascript, improved OAuth2 test clarity
packages/spec/src/data/external-lookup.test.ts Updated all field mappings from externalField/localField to canonical source/target properties
packages/spec/src/automation/workflow.test.ts Wrapped webhook trigger action URL in proper config object structure matching WebhookSchema
packages/spec/src/auth/config.test.ts Corrected schema reference from non-existent EnterpriseApplicationAuthConfigSchema to EnterpriseAuthConfigSchema
packages/spec/src/ai/conversation.test.ts Added required completion: 0 field to token usage object for user message

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants