fix(i18n): fill 25 missing ja-JP page-component translation keys - #1084
Merged
Conversation
objectstack lint (run without --skip-i18n since #1080) reported 25 i18n/missing-page warnings, all ja-JP: page-component label/title/description strings on app_launcher_page, case_detail_page, lead_detail_page, opportunity_detail_page, sales_home_page and utility_bar_page that were defined in src/pages/*.page.ts and never mirrored into src/translations/ja-JP.ts. #1080 filled the same 25 keys for es-ES/zh-CN but left ja-JP.ts untouched because it was claimed by #858 (verb-terminology pass) in the same batch. That claim merged (83a8dbd); this fills the remaining third. Translated against each page's English source, matching the nesting shape #1080 already established for es-ES/zh-CN. Additions only -- no existing ja-JP.ts lines reordered, to avoid a needless conflict for #1061 which is queued behind this file. objectstack lint now reports zero i18n/missing-page warnings (down from 25; 178 -> 153 total warnings). Fixes #1060 Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01NM6o28jmBgsyTRQHutn7LC
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
huangyiirene
marked this pull request as ready for review
August 11, 2026 15:12
This was referenced Aug 11, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1060
What
Fills the remaining third of #1060's debt: the 25
ja-JPpage-componenttranslation keys that #1080 deliberately left out (that file was claimed by
#858 in the same batch). #858's PR #1079 merged (
83a8dbdb), and this branchis cut from current
origin/main(f71b5350, which already carries both#1079 and #1080), so the cross-claim boundary is clear.
Premise re-verified at HEAD, not copied from the issue
Ran
npx objectstack lintfresh on this branch before touching anything. Itreported exactly 25
i18n/missing-pagewarnings, allja-JP, and thekey paths matched the PM's enumerated list exactly:
app_launcher_page.components.{app_search,app_grid}.labelcase_detail_page.components.{case_highlights,case_status_path}.labellead_detail_page.components.{lead_highlights,lead_path,main_tabs}.labelopportunity_detail_page.components.{opp_highlights,opp_stage_path}.labelsales_home_page.components.{quick_create,my_recent_items,key_metrics,home_tabs,ai_briefing,upcoming_events}.{title|label|description}utility_bar_page.components.{notifications_panel,quick_notes,quick_search}.{title|label}es-ESandzh-CNreported zeroi18n/missing-pagewarnings — confirming#1080's fill is intact and untouched by this change.
Implementation
Translated each string against its English source in
src/pages/*.page.ts(
app_launcher.page.ts,case_detail.page.ts,lead_detail.page.ts,opportunity_detail.page.ts,home.page.ts,utility_bar.page.ts), matchingthe nesting shape and register #1080 already established for
es-ES/zh-CN(
pages.<page>.components.<component>.<label|title|description>).File surface:
src/translations/ja-JP.tsonly — additions, no existinglines reordered or reformatted, per the card's instruction not to create a
needless conflict for #1061, which is queued behind this file for the
crm_opportunitycompetitors options (a disjoint region —crm_opportunityfield block vs. this PR's
pagesblock).Acceptance evidence
objectstack linti18n/missing-pagecount:i18n/missing-pagewarningsja-JP)(
lint's exit code is 0 either way — it does not fail on warnings, per#1083 — so the rule-hit count above, not the exit code, is the evidence.)
Tests run
npx objectstack lint(no flag): 0i18n/missing-pagehits, 153 totalwarnings (down from 178), exit 0.
pnpm typecheck(tsc --noEmit): clean, no errors.pnpm validate(objectstack validate): exit 0; remaining warnings arepre-existing, unrelated author-time issues (missing
nameon formsections, deprecated component props,
colSpanusage) — none i18n, nonetouching
ja-JP.ts.pnpm build(objectstack build): exit 0,dist/objectstack.jsonproduced(1890.1 KB), 157 pre-existing author-time warnings (none i18n).
npx vitest run test/i18n-references.test.ts --maxWorkers=2: 20/20 passed.npx vitest run --maxWorkers=2(full scoped suite): 86 files, 2086 passed /1 skipped, exit 0.
node scripts/check-source-hygiene.mjs: clean.grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f\x7f]') onthe edited file: clean.
Changeset
Added (
skip-changesetnot applicable — this is a user-visible translationfill; the
ja-JPUI previously fell back to English source strings on these25 component keys).
Generated by Claude Code