fix(skills): drop the per-skill permissions keys — the field does not exist in SkillSchema - #511
Merged
Merged
Conversation
…ot exist in SkillSchema (objectstack#3820) All six skills declared `permissions: ['crm:…']`. SkillSchema has no such field, so Zod strips the key at parse time: it granted and restricted nothing while reading as a security control — the ADR-0049 prohibited shape, flagged in objectstack#3820 §4. Access to AI capability is gated at the agent level (`agent.access`/`agent.permissions`, enforced at the chat route) and by each tool's own authz; the spec now documents this on SkillSchema itself (objectstack#3871). typecheck, `objectstack validate`, and the test suite (67) all pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01BHjroNkLkajskKbJaidko4
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
os-zhuang
marked this pull request as ready for review
July 28, 2026 13:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
All six skills declared
permissions: ['crm:…'].SkillSchemahas no such field, so Zod strips the key at parse time — it granted and restricted nothing while reading as a security control. That is the ADR-0049 prohibited shape (a security-shaped declaration that lies), flagged in objectstack-ai/objectstack#3820 §4.Where access is actually gated:
agent.access/agent.permissions, enforced at the chat route;The spec now documents this directly on
SkillSchema(objectstack-ai/objectstack#3871), so the next author — human or AI — is told before writing the key instead of having it silently vanish.Diff is deletion-only (12 lines across 6
*.skill.ts).pnpm typecheck,objectstack validate, and the test suite (8 files / 67 tests) all pass.Refs objectstack-ai/objectstack#3820 · sibling PRs objectstack-ai/objectstack#3871, objectstack-ai/cloud#904
🤖 Generated with Claude Code
https://claude.ai/code/session_01BHjroNkLkajskKbJaidko4
Generated by Claude Code