test: drop the now-stale unguarded-predicate exemption (unbreaks main) - #572
Merged
Conversation
main is red: test/object-validation-predicates.test.ts > 'keeps no stale entries in the known-unguarded list' fails with ["crm_opportunity_line_item.unit_price_positive"]. Nothing is broken — the guard fired exactly as designed. #571 carved that rule out as a documented exemption because it belongs to a different object family, and paired the exemption with a staleness check so it could not rot. #570, run in parallel, added the guard to that very rule. Both PRs were green on their own branch; the collision only exists on main, where the exemption is now stale. Emptying the map is the fix the check was written to force. verify: exit 0, 0 errors, 436 passed | 2 skipped, 24 files. Refs #514. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
mainis red.test/object-validation-predicates.test.ts› keeps no stale entries in the known-unguarded list fails:Nothing is broken — the guard fired exactly as designed.
What happened
#571 could not fix
crm_opportunity_line_item.unit_price_positive(it belongs to a different object family than that PR's scope), so it recorded the rule as a documented exemption and paired it with a staleness check, precisely so the exemption could not quietly outlive its fix.#570, running in parallel, added the guard to that very rule.
Both PRs were green on their own branch. The collision exists only on
main, where the exemption is now stale — which is the exact condition #571's check was written to detect. Emptying the map is the fix it was asking for.This is the third instance today of "individually green, red after merge" (the others: #547's dangling
crm_competitorgrants, #439's stale StackBlitz lockfile). Worth noting that this one is the only one a test caught automatically — the other two had to be found by hand.Changes
KNOWN_UNGUARDEDis now empty, with a comment recording why the entry existed and how it died, so the next reader understands the mechanism rather than just seeing an empty object.Verification
pnpm verifyon a clean checkout:@objectstack 17+bucket assertionsType of Change
Checklist
pnpm verifypassesRefs #514.