docs(integrations): narrow the "no Setup → Integrations menu" claims to what is measured (#800) - #908
Merged
Conversation
…to what is measured (#800) The Integrations guide asserted, in two places, that the menu itself does not exist: "no `Setup → Integrations` menu" in the connector section, and "no `Setup → Integrations → Webhooks` screen to find one under" in the webhooks section. Measured against the installed platform packages, the group is real — `SETUP_APP` in `@objectstack/platform-objects` declares nine navigation groups and `group_integrations` is one of them, with three packages contributing entries into it (`plugin-webhooks` → Webhooks + HTTP Deliveries, `service-datasource` → Datasources, `mcp` → Connect an Agent). The webhooks claim was the one that would break under the page's own advice: the note directly beneath it tells the reader to add `webhooks` to `requires`, which is exactly what makes `plugin-webhooks` mount the screen the sentence said did not exist. Both sentences now state the narrower fact — the group exists, and nothing this app enables mounts a vendor connector under it — keeping "not shipped" (the ten connectors), "not enabled here" (webhooks) and "exists but carries no connector entries" (the group) as three distinct statements. The lead paragraph carried a third copy of the same absolute clause and moves with them. No claim from #762 is reverted: `src/` still carries no connector metadata, no platform package ships a connector for any of those ten vendors, and every `Setup → Integrations → X` path the table used to print still points at a screen that does not exist. en / zh-Hans / zh-Hant updated together. Co-Authored-By: Claude <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01VHrPAGEgFDoHjphqYG4BMa
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
yinlianghui
marked this pull request as ready for review
August 6, 2026 06:50
This was referenced Aug 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #800
把
content/docs/guides/integrations.mdx(en / zh-Hans / zh-Hant)里两句绝对语气收成范围语气:设置 → 集成这个分组在平台 Setup 应用里真实存在,今天没有的是「本应用启用了、并且会往它下面挂厂商连接器条目」的能力。PR #762 的核心主张一条没动。前提复核(origin/main = 90686a4,
@objectstack/*17.0.0-rc.2)1. 两句在最新 main 上的位置(与 issue 给的行号有出入)
issue 写的是
:19与:106,实测两句分别在:23与:82(三个 locale 文件一致)。#762 之后该页只被 #843 动过一次(导出那一条 bullet,:15),行号自 #762 起未变 —— 也就是说:19/:106是 issue 正文的近似行号,不是漂移。引文本身逐字对得上,定位无歧义。另有第三处同一断言:该页导语
:8也写着「也不存在可用来配置连接器的 设置 → 集成 菜单」。issue 的实测段没有引到它。只改:23会让同一页的导语和正文互相矛盾,故一并纳入(同一句话、同一个事实,不是范围扩张;#762 的其它主张仍零回退)。2. 九个导航分组(
SETUP_APP,@objectstack/platform-objects@17.0.0-rc.2)node_modules/@objectstack/platform-objects/dist/apps/index.mjs只读复测,九个 group 依次是:group_integrations(labelIntegrations,iconplug,requiredPermissions: ["manage_platform_settings"])自身children: []—— 条目全部来自外部贡献。把node_modules/@objectstack里所有app: "setup"的贡献目标扫一遍,只落在这九个 group 上,没有第十个分组:3. 三个往
group_integrations挂条目的包(逐个复测到源码行)@objectstack/plugin-webhookssys_webhook)、HTTP Deliveries(sys_http_delivery)dist/index.js:522-532,priority 100@objectstack/service-datasourcedist/index.js:1204-1220,priority 100,在DatasourceAdminServicePlugin.init()里无条件注册@objectstack/mcpdist/index.js:991-1006(CONNECT_AGENT_UI_BUNDLE),priority 110,kernel:ready时注册4.
requires与平台常开清单复测objectstack.config.ts:84→requires: ['automation', 'triggers', 'analytics', 'auth', 'ui', 'approvals', 'sharing'](与页面里印的一致)。PLATFORM_ALWAYS_ON_CAPABILITIES(@objectstack/spec/kernel,实跑):webhooks两处都不在 —— 且serve.js的能力→插件表里webhooks只有「requires命中才加载」这一条路径,没有任何默认加载分支。webhooks确实未启用,issue 这一半成立。5. 复核中发现 issue 的一处论据不成立(如实报,未写进文档)
issue 说「这三个能力一个都没加载……分组因此是空的」。实测
mcp与datasource这两项在默认部署里是加载的:@objectstack/cli/dist/commands/serve.js:768——if (isMcpServerEnabled() && !requires.includes('mcp')) requires.push('mcp');isMcpServerEnabled()在OS_MCP_SERVER_ENABLED未设时返回true(@objectstack/types:124-130),本仓没有任何.env关掉它,而pnpm dev/pnpm start都走objectstack dev|start→serve。serve.js:2277起无条件挂载DatasourceAdminServicePlugin(注释原文:"Mounted by default so a self-host runtime is a complete low-code platform out of the box"),datasource根本不是PLATFORM_CAPABILITY_TOKENS里的能力词条,不受requires约束。也就是说 HotCRM 今天的
设置 → 集成下大概率有 Datasources 与 Connect an Agent 两个平台条目,分组并不空 —— 这只让原句「没有这个菜单」错得更明确,不改变本单的修法。改写措辞按「没有任何厂商连接器条目」写,不写「分组是空的」,因此文档不依赖这条未经浏览器实测的推断;该发现另行归档(见文末)。两句(实为三句)改文,三语对照
A. 导语
:8B. 内置连接器段
:23(issue 的第 1 条)Setup → Integrationsmenu.」设置 → 集成菜单」→「设置 → 集成这个分组本身是存在的——它是平台 Setup 应用声明的九个导航分组之一,另外八个是概览、应用、人员与组织、访问控制、审批、配置、诊断与高级——但下面这张表里的厂商,没有一家会往它下面挂条目」設定 → 整合選單」→「設定 → 整合這個分組本身是存在的……但下面這張表裡的廠商,沒有一家會往它底下掛項目」(术语按该 locale 既有写法:導覽 / 分組 / 外掛 / 中繼資料;九个分组的译名沿用import-and-export.zh-Hant.mdx:10已有的那一套)后半句「照着走的人,去找的是一个并不存在的界面」原样保留 —— 那十条
Setup → Integrations → X路径今天依然指向不存在的界面。C. Webhooks 段
:82(issue 的第 2 条)Setup → Integrations → Webhooksscreen to find one under.」@objectstack/plugin-webhooksunloaded, the two Setup entries it contributes — Webhooks and HTTP Deliveries — do not appear underSetup → Integrations. That is not enabled here, not not built: turn the capability on as the note below describes and the plugin mounts them itself.」设置 → 集成 → Webhooks这样一个页面可去」→「……@objectstack/plugin-webhooks没有被加载,它贡献的两个 Setup 条目——Webhooks 与 HTTP Deliveries——也就不会出现在设置 → 集成下面。这是本应用没启用,不是平台没做:按下面那段提示把这项能力打开,插件自己就会把它们挂上去。」这一句是本单的实际收益:紧接其后的提示框写着「把
webhooks加进requires,声明你的订阅」,读者照做后设置 → 集成 → Webhooks就会出现 —— 页面自己的操作建议与页面自己的绝对断言在同一次部署里对撞的休眠矛盾,到此消除。三态区分(issue 的判据)
改写后这三种状态在页面上各说各的,不再混成一句「不存在」:
*.connector.tssrc/无连接器元数据,平台包无对应插件(#762 主张,零改动)webhooksrequires;启用即由plugin-webhooks自己挂进设置 → 集成设置 → 集成分组PR #762 零回退核对
(not shipped yet)标注、「设计意图 / 需求规格」的读法说明 —— 全部未动。Setup → Integrations → X配置路径指向不存在的界面:该结论句保留(:23后半句原文)。src/无连接器元数据 / 平台包无连接器插件:两条原文保留,只删掉了并列在后面的「更没有菜单」那一个从句。*.connector.ts各段:未动。验证(共享锁 +
NODE_OPTIONS=--max-old-space-size=4096)pnpm validate✓ Validation passed (1342ms);5 条 author-time warning 与 main 同pnpm typechecktsc --noEmit无输出pnpm build✓ Build complete (1602ms)/Artifact: dist/objectstack.json (1921.4 KB)pnpm test -- --maxWorkers=2Test Files 66 passed (66)/Tests 1587 passed | 1 skipped (1588)(source-hygiene 元测试的✗ …stderr 为预期)pnpm lint13 warning(s), 14 suggestion(s)—— 与 main 同pnpm hygiene✓ no raw control bytes in first-party files/✓ source hygiene clean(扫描面含content、.changeset,共 409 个文本文件)控制字节自扫(改动的三个 mdx + changeset):
grep -naP '[\x00-\x08\x0b\x0c\x0e-\x1f]'零命中。changeset:
.changeset/integrations-scope-wording.md('hotcrm': patch)。场外发现
第 5 节那条(
mcp/datasource默认加载,设置 → 集成今天并不空,而整个content/docs从未提到 MCP 端点与 Datasources 这两个真实存在的对外 / 管理面)不在本单文件面内,按 Prime Directive #10 单独立项,不在本 PR 修。Generated by Claude Code